php.net |  support |  documentation |  report a bug |  advanced search |  search howto |  statistics |  random bug |  login
Request #56169 Package RSS Release Feed
Submitted: 2004-08-16 12:14 UTC Modified: 2004-11-14 09:37 UTC
From: asnagy@php.net Assigned:
Status: Closed Package: PECL website (PECL)
PHP Version: 4.3.7 OS:
Private report: No CVE-ID: None
View Add Comment Developer Edit
Welcome! If you don't have a Git account, you can't do anything here.
You can add a comment by following this link or if you reported this bug, you can edit this bug over here.
Block user comment
Status: Assign to:
Package:
Bug Type:
Summary:
From: asnagy@php.net
New email:
PHP Version: OS:

 

 [2004-08-16 12:14 UTC] asnagy@php.net
Description:
------------
Can the Links in the RSS Release Feed point back to the appropriate download page instead of just back to the package page?


Expected result:
----------------
<a href="http://pear.php.net/package/Structures_DataGrid/download/0.5.3">Structures_DataGrid 0.5.3</a>

<a href="http://pear.php.net/package/Structures_DataGrid/download/0.5.2">Structures_DataGrid 0.5.2</a>

Actual result:
--------------
<a href="http://pear.php.net/package/Structures_DataGrid">Structures_DataGrid 0.5.3</a>

<a href="http://pear.php.net/package/Structures_DataGrid">Structures_DataGrid 0.5.2</a>

Patches

Add a Patch

Pull Requests

Add a Pull Request

History

AllCommentsChangesGit/SVN commitsRelated reports
 [2004-10-28 12:44 UTC] helgi at trance dot is
This is because it's a about link, i.e. the package info page , maybe we could add one other element which would be rdf:download and there is what your requesting, how does that sound ?
 [2004-10-28 15:13 UTC] asnagy at webitecture dot org
Well what's the point of linking back to the package homepage in relevance to the releases, it's the Release RSS feed we are taling about?

I think the about URL should go to page the has information ABOUT the specific release.  It just doesn't make any sense to be any other way.

It might be nice to also have another element which is an actual download link such as:

<rdf:download>http://pear.php.net/get/Structures_DataGrid-0.5.3.tgz</rdf:download>
 [2004-10-28 15:26 UTC] helgi at trance dot is
To keep BC I'd rather like to keep the about as is, and maybe rather add that download idea, and about-release ...
 [2004-10-28 15:58 UTC] mj@php.net
I don't think we need to worry about backwards compatibility too much in this respect, and I like Andrew's suggestion.
 [2004-10-28 16:02 UTC] helgi at trance dot is
Okey cool, I just assumed it had to be BC like the rest of PEAR ;)

So where changing the about tag and also adding the download tag, right ?
 [2004-10-28 16:11 UTC] mj@php.net
I was thinking of something like

Index: Common.php
===================================================================
RCS file: /repository/pearweb/include/Damblan/RSS/Common.php,v
retrieving revision 1.10
diff -u -r1.10 Common.php
--- Common.php  20 Mar 2004 17:35:39 -0000      1.10
+++ Common.php  28 Oct 2004 20:09:05 -0000
@@ -121,7 +121,7 @@
     function __addItems($list) {
         foreach ($list as $item) {
             $date = date("Y-m-d\TH:i:s-05:00", strtotime($item['releasedate']));
-            $node = $this->newItem($item['name'] . " " . $item['version'], "http://pear.php.net/package/" . $item['name'], $item['releasenotes'], $date);
+            $node = $this->newItem($item['name'] . " " . $item['version'], "http://pear.php.net/package/" . $item['name'] . "/download/" . $item['version'] . "/", $item['releasenotes'], $date);
             $this->addItem($node);
         }
     }
 [2004-10-28 16:29 UTC] helgi at trance dot is
Yeah sounds, good, would do the trick for the about part, but what about what Andrew proposed regarding having a straight link to the .tgz of the package also ?
 [2004-11-14 09:37 UTC] helgi at trance dot is
This bug has been fixed in CVS.

In case this was a documentation problem, the fix will show up at the
end of next Sunday (CET) on pear.php.net.

In case this was a pear.php.net website problem, the change will show
up on the website in short time.
 
Thank you for the report, and for helping us make PEAR better.

Implanted, <link> now links to the release info, plus I added a <download> tag with the info on the url to the .tgz for the  release
 
PHP Copyright © 2001-2020 The PHP Group
All rights reserved.
Last updated: Wed Dec 02 04:01:24 2020 UTC