php.net |  support |  documentation |  report a bug |  advanced search |  search howto |  statistics |  random bug |  login

go to bug id or search bugs for

Bug #55710 win32 and devel directories not created by makefile.
Submitted: 2011-09-16 12:11 UTC Modified: 2019-07-15 19:04 UTC
Votes:1
Avg. Score:3.0 ± 0.0
Reproduced:0 of 0 (0.0%)
From: RQuadling at GMail dot com Assigned: jbnahan (profile)
Status: Closed Package: *Compile Issues
PHP Version: Irrelevant OS: Windows
Private report: No CVE-ID: None
View Add Comment Developer Edit
Welcome! If you don't have a Git account, you can't do anything here.
You can add a comment by following this link or if you reported this bug, you can edit this bug over here.
(description)
Block user comment
Status: Assign to:
Package:
Bug Type:
Summary:
From: RQuadling at GMail dot com
New email:
PHP Version: OS:

 

 [2011-09-16 12:11 UTC] RQuadling at GMail dot com 
Description:
------------
The win32 and devel directories are only created during configure.js.

If, after a success nmake, the release directory is deleted, the win32 and devel 
directories are not recreated.

win32 and devel is never added to BUILD_DIRS_SUB (via ADD_FLAGS).

Having added "win32" to the build_dirs array initialization, the win32 directory 
will still fail to be created in a particular instance.

The ADD_FLAG routine uses indexOf() to determine if "win32" is already part of 
the flags. If an extension containing the characters "win32" already exists 
(pecl/win32service for example), then the "win32" check will fail and no "win32" 
will be added to BUILD_DIRS_SUB.

The "devel" directory is only added if !MODE_PHPIZE is true. But putting 
ADD_FLAG("BUILD_DIRS_SUB", "devel"); in generate_phpize(); is too late as 
generate_makefile(); has already been called.

I don't want to do too much with this as I'm not 100% sure, so the additional 
test for "devel" has been added in the attached patch.

The supplied patch deals with these issues.

The end result is just that "win32" and, if appropriate "devel" are added to 
BUILD_DIRS_SUB so a nmake will always create them if they are missing.

Patches

missing_dirs.patch (last revision 2011-09-16 12:27 UTC by rquadling@php.net)

Add a Patch

Pull Requests

Add a Pull Request

History

AllCommentsChangesGit/SVN commitsRelated reports
 [2011-09-16 12:27 UTC] rquadling@php.net 
Seems the ADD_FLAG() fix is all that is needed for the win32 directory.

New patch created.
 [2011-09-16 12:27 UTC] rquadling@php.net 
The following patch has been added/updated:

Patch Name: missing_dirs.patch
Revision:   1316176068
URL:        https://bugs.php.net/patch-display.php?bug=55710&patch=missing_dirs.patch&revision=1316176068
 [2019-07-15 19:04 UTC] jbnahan@php.net
-Status: Open +Status: Closed -Assigned To: +Assigned To: jbnahan
 
PHP Copyright © 2001-2024 The PHP Group
All rights reserved. 		Last updated: Wed Apr 24 05:01:30 2024 UTC