php.net |  support |  documentation |  report a bug |  advanced search |  search howto |  statistics |  random bug |  login

go to bug id or search bugs for

Request #55255 Add option to commit via diff view
Submitted: 2011-07-20 19:04 UTC Modified: 2011-12-08 18:19 UTC
From: philip@php.net Assigned: yannick (profile)
Status: Closed Package: Online Doc Editor problem
PHP Version: Irrelevant OS: All
Private report: No CVE-ID: None
View Add Comment Developer Edit
Welcome! If you don't have a Git account, you can't do anything here.
You can add a comment by following this link or if you reported this bug, you can edit this bug over here.
(description)
Block user comment
Status: Assign to:
Package:
Bug Type:
Summary:
From: philip@php.net
New email:
PHP Version: OS:

 

 [2011-07-20 19:04 UTC] philip@php.net 
Description:
------------
It should be easier to commit a patch. When in diff mode, and after reviewing said 
diff for mistakes, it'd be nice to be able to commit it without hunting for the 
filename within the sidebar. It would be nice if the top navigation bar 
offered/allowed these options.

Patches

Add a Patch

Pull Requests

Add a Pull Request

History

AllCommentsChangesGit/SVN commitsRelated reports
 [2011-07-23 22:24 UTC] yannick@php.net 
I make a preview here :

https://picasaweb.google.com/yannick.torres/Request55255#5632675929475446370

This top tools bar will be available for diff view & unified diff view.

Is it what you mean ?
 [2011-07-23 22:38 UTC] yannick@php.net
-Status: Open +Status: Feedback -Assigned To: +Assigned To: yannick
 [2011-07-27 05:05 UTC] philip@php.net 
That looks good, except I wonder if allowing all of the files options would be more useful. So, this includes "Edit in new tab" and the "Administrator" 
options [when available] which means using the same dialogue as right clicking on the diff'ed file. What do you think?
 [2011-12-08 18:18 UTC] yannick@php.net 
Automatic comment from SVN on behalf of yannick
Revision: http://svn.php.net/viewvc/?view=revision&revision=320685
Log: Fix bug #55255 : Add a top bar to diff panel allowing some action
 [2011-12-08 18:19 UTC] yannick@php.net
-Status: Feedback +Status: Closed
 [2011-12-08 18:19 UTC] yannick@php.net 
This bug has been fixed in SVN, and should show up online in an
hour or three.

Thank you for the report, and for helping us make PHP.net better.
 
PHP Copyright © 2001-2024 The PHP Group
All rights reserved. 		Last updated: Tue Apr 30 13:01:32 2024 UTC