php.net |  support |  documentation |  report a bug |  advanced search |  search howto |  statistics |  random bug |  login
Bug #53172 ZEND_ACC_IMPLICIT_PUBLIC should be removed or used in zend_get_property_info
Submitted: 2010-10-26 18:34 UTC Modified: 2010-10-26 20:25 UTC
From: cataphract@php.net Assigned:
Status: Open Package: Scripting Engine problem
PHP Version: 5.3SVN-2010-10-26 (SVN) OS:
Private report: No CVE-ID: None
View Add Comment Developer Edit
Welcome! If you don't have a Git account, you can't do anything here.
You can add a comment by following this link or if you reported this bug, you can edit this bug over here.
(description)
Block user comment
Status: Assign to:
Package:
Bug Type:
Summary:
From: cataphract@php.net
New email:
PHP Version: OS:

 

 [2010-10-26 18:34 UTC] cataphract@php.net
Description:
------------
The status of the flag ZEND_ACC_IMPLICIT_PUBLIC is somewhat unclear. In the ZE:

* PHP 5.3 checks for it in a few places, but doesn't set it anymore as the body of zend_do_declare_implicit_property is commented out.
* trunk retains only the definition of ZEND_ACC_IMPLICIT_PUBLIC, everything else is gone.

So it seems that the flag ZEND_ACC_IMPLICIT_PUBLIC, apparently originally used to signal dynamic properties, is only used by the reflection extension. The reflection extension, not being able to depend on the Zend Engine to set it, sets the flag itself when it finds a dynamic property, i.e. a property that is in the object hash table but has no property_info (ReflectionProperty::__construct and ReflectionClass::getProperty).

This would be unnecessary if zend_get_property_info set the flag ZEND_ACC_IMPLICIT_PUBLIC over here:

http://lxr.php.net/opengrok/xref/PHP_TRUNK/Zend/zend_object_handlers.c#310

In that case, the reflection extension could just call zend_get_property_info and not do directly lookups in ce->properties_info. Though right now it would be possible to call zend_get_property_info and check for equality to &EG(property_info), this is suboptimal.


Patches

Add a Patch

Pull Requests

Add a Pull Request

History

AllCommentsChangesGit/SVN commitsRelated reports
 [2010-10-26 20:25 UTC] cataphract@php.net
I recall the last paragraph, zend_get_property_info is not an alternative for reflection because of the access checks (except for _adddynproperty).
 
PHP Copyright © 2001-2019 The PHP Group
All rights reserved.
Last updated: Wed Sep 18 20:01:27 2019 UTC