php.net |  support |  documentation |  report a bug |  advanced search |  search howto |  statistics |  random bug |  login
Bug #51022 getservbyname_basic.phpt has incorrect description and misses a skip case
Submitted: 2010-02-11 21:29 UTC Modified: 2010-02-16 05:39 UTC
From: geissert at debian dot org Assigned:
Status: Closed Package: Network related
PHP Version: 5.3.1 OS: debian sid
Private report: No CVE-ID: None
View Add Comment Developer Edit
Welcome! If you don't have a Git account, you can't do anything here.
You can add a comment by following this link or if you reported this bug, you can edit this bug over here.
(description)
Block user comment
Status: Assign to:
Package:
Bug Type:
Summary:
From: geissert at debian dot org
New email:
PHP Version: OS:

 

 [2010-02-11 21:29 UTC] geissert at debian dot org
Description:
------------
The description of ext/standard/tests/general_functions/getservbyname_basic.phpt is incorrect, as that's not really what the test is about.
Additionally, a SKIP section should be added to skip the test if /etc/services does not exist.



Patches

Add a Patch

Pull Requests

Add a Pull Request

History

AllCommentsChangesGit/SVN commitsRelated reports
 [2010-02-12 16:26 UTC] jani@php.net
Why would you not have /etc/services and how is the description wrong?
(patches are welcome..)
 [2010-02-12 18:42 UTC] geissert at debian dot org
Maybe because it says:
Test function getservby*port*() by *calling it more than or less than its expected arguments*

The test does nothing of that :)

As to why /etc/services (and friends) wouldn't exist: because it is only required for networking (not going to strongly push that change, though.)
 [2010-02-16 05:38 UTC] svn@php.net
Automatic comment from SVN on behalf of geissert
Revision: http://svn.php.net/viewvc/?view=revision&revision=295137
Log: Correct description of getservbyname_basic.phpt (bug #51022)
 [2010-02-16 05:39 UTC] geissert@php.net
This bug has been fixed in SVN.

Snapshots of the sources are packaged every three hours; this change
will be in the next snapshot. You can grab the snapshot at
http://snaps.php.net/.
 
Thank you for the report, and for helping us make PHP better.


 
PHP Copyright © 2001-2022 The PHP Group
All rights reserved.
Last updated: Tue Jan 18 17:03:14 2022 UTC