php.net |  support |  documentation |  report a bug |  advanced search |  search howto |  statistics |  random bug |  login

go to bug id or search bugs for

Bug #50889 Patch-Request: Fixes to confutils.js
Submitted: 2010-01-30 21:20 UTC Modified: 2010-03-25 04:49 UTC
From: thomas dot worm at thomas-worm dot de Assigned: kalle (profile)
Status: Closed Package: PHP-GTK related
PHP Version: 5.3.1 OS: Windows
Private report: No CVE-ID: None
View Add Comment Developer Edit
Welcome back! If you're the original bug submitter, here's where you can edit the bug or add additional notes.
If this is not your bug, you can add a comment by following this link.
If this is your bug, but you forgot your password, you can retrieve your password here.
Password:
Status:
Package:
Bug Type:
Summary:
From: thomas dot worm at thomas-worm dot de
New email:
PHP Version: OS:

 

 [2010-01-30 21:20 UTC] thomas dot worm at thomas-worm dot de 
Description:
------------
- If php-gtk is compiled without extensions configure.js will run into 
an error because MFE is completely empty.
- Sometimes configure.js doesn't write !ENDIF although !IF is always 
written. So make isn't able to parse the Makefile

This can be fixed with following patch:

diff -Nur php-gtk.orig/win32/confutils.js php-gtk/win32/confutils.js
--- php-gtk.orig/win32/confutils.js	2010-01-16 19:02:31.068819700 
+0100
+++ php-gtk/win32/confutils.js	2010-01-16 20:08:36.402623800 +0100
@@ -991,6 +991,7 @@
 
 function generate_makefile() {
 
+    MFE.WriteLine(""); // To avoid error if MFE will be complete 
empty
 	MFE.Close(); // Makefile.extensions is now complete
 	MFO.Close(); // Makefile.objects is now complete
 	var MF = FSO.CreateTextFile("Makefile", true);
@@ -1022,8 +1023,8 @@
 	if (make_builds.length > 1) {
 		MF.WriteLine("!ELSE");
 		MF.WriteLine("!MESSAGE Note: $(PHPGTKLIB) must be 
created before PHP-GTK extensions can be built");
-		MF.WriteLine("!ENDIF");
 	}
+	MF.WriteLine("!ENDIF");
 
 	MF.WriteLine("build_dirs: $(BUILD_DIR) $(BUILD_DIRS_SUB)");
 	MF.WriteBlankLines(1);

Reproduce code:
---------------
cscript /nologo configure.js

Expected result:
----------------
configure.js runs well
nmake is executed

Actual result:
--------------
configure.js crashed when MFE is completely empty
nmake isn't able to read Makefile

Patches

Add a Patch

Pull Requests

Add a Pull Request

History

AllCommentsChangesGit/SVN commitsRelated reports
 [2010-03-17 18:22 UTC] kalle@php.net
-Assigned To: auroraeosrose +Assigned To: kalle
 [2010-03-17 18:22 UTC] kalle@php.net 
Re-assigned to my-self, I will take a look shortly
 [2010-03-25 04:49 UTC] kalle@php.net 
Automatic comment from SVN on behalf of kalle
Revision: http://svn.php.net/viewvc/?view=revision&revision=296771
Log: Fixed bug #50889 (Fixes to confutils.js) - Patch by thomas dot worm at thomas-worm dot de
 [2010-03-25 04:49 UTC] kalle@php.net
-Status: Assigned +Status: Closed
 [2010-03-25 04:49 UTC] kalle@php.net 
This bug has been fixed in SVN.

Snapshots of the sources are packaged every three hours; this change
will be in the next snapshot. You can grab the snapshot at
http://snaps.php.net/.
 
Thank you for the report, and for helping us make PHP better.
 
PHP Copyright © 2001-2024 The PHP Group
All rights reserved. 		Last updated: Tue Apr 23 23:01:29 2024 UTC