php.net |  support |  documentation |  report a bug |  advanced search |  search howto |  statistics |  random bug |  login

go to bug id or search bugs for

Bug #50888 Patch Request: Detection of Microsoft VS.NET 2008
Submitted: 2010-01-30 21:15 UTC Modified: 2010-03-17 17:00 UTC
From: thomas dot worm at thomas-worm dot de Assigned: kalle (profile)
Status: Closed Package: PHP-GTK related
PHP Version: 5.3.1 OS: Windows
Private report: No CVE-ID: None
View Add Comment Developer Edit
Anyone can comment on a bug. Have a simpler test case? Does it work for you on a different platform? Let us know!
Just going to say 'Me too!'? Don't clutter the database with that please !
Your email address:
MUST BE VALID
Solve the problem:
18 + 7 = ?
Subscribe to this entry?

 
 [2010-01-30 21:15 UTC] thomas dot worm at thomas-worm dot de 
Description:
------------
When you compile PHP-GTK with Microsoft VS.NET 2008 the compiler will 
not be detected properly.

This could be fixed with following patch:


diff -ruN php-gtk.orig/win32/config.w32.in php-gtk/win32/config.w32.in
--- php-gtk.orig/win32/config.w32.in	2010-01-16 19:02:31.074820100 
+0100
+++ php-gtk/win32/config.w32.in	2010-01-16 19:05:17.334329600 +0100
@@ -40,6 +40,9 @@
 	if (VCVERS == 14) {
 		msversion = "Microsoft VS.NET 2005";
 	}
+	if (VCVERS == 15) {
+		msversion = "Microsoft VS.NET 2008";
+	}
 	STDOUT.WriteLine("Detected compiler version:  " + msversion);
 
 } else {

Reproduce code:
---------------
cscript /nologo configure.js

Expected result:
----------------
Detected compiler version: Microsoft VS.NET 2008

Actual result:
--------------
Detected compiler version:  unknown

Patches

Add a Patch

Pull Requests

Add a Pull Request

History

AllCommentsChangesGit/SVN commitsRelated reports
 [2010-03-16 18:39 UTC] kalle@php.net
-Status: Open +Status: Assigned -Assigned To: +Assigned To: kalle
 [2010-03-16 18:39 UTC] kalle@php.net 
Assigned to myself, I got a patch which detects the other missing MSVC versions along with a few other improvements to the Windows build of GTK.
 [2010-03-17 17:00 UTC] kalle@php.net 
Automatic comment from SVN on behalf of kalle
Revision: http://svn.php.net/viewvc/?view=revision&revision=296329
Log: Improve Windows build system take #1
 * Generate configure.bat
 * Use php_gtk_build as first priority build folder to prevent interfering with php-src builds
 * Write 2 blank lines before the error message in ERROR() to prevent error messages while detecting locations to look screwy
 * Proper detect MSVC versions, merged from php-src (Fixes #50888)
 [2010-03-17 17:00 UTC] kalle@php.net
-Status: Assigned +Status: Closed
 [2010-03-17 17:00 UTC] kalle@php.net 
This bug has been fixed in SVN.

Snapshots of the sources are packaged every three hours; this change
will be in the next snapshot. You can grab the snapshot at
http://snaps.php.net/.
 
Thank you for the report, and for helping us make PHP better.
 
PHP Copyright © 2001-2024 The PHP Group
All rights reserved. 		Last updated: Tue Apr 16 12:01:29 2024 UTC