php.net |  support |  documentation |  report a bug |  advanced search |  search howto |  statistics |  random bug |  login
Request #48421 stream_get_line() - allow $length to be optional
Submitted: 2009-05-28 22:42 UTC Modified: 2015-01-03 13:27 UTC
Votes:5
Avg. Score:4.4 ± 0.8
Reproduced:5 of 5 (100.0%)
Same Version:4 (80.0%)
Same OS:5 (100.0%)
From: ryan dot brothers at gmail dot com Assigned:
Status: Open Package: Streams related
PHP Version: Any OS: Irrelevant
Private report: No CVE-ID: None
View Add Comment Developer Edit
Welcome! If you don't have a Git account, you can't do anything here.
You can add a comment by following this link or if you reported this bug, you can edit this bug over here.
(description)
Block user comment
Status: Assign to:
Package:
Bug Type:
Summary:
From: ryan dot brothers at gmail dot com
New email:
PHP Version: OS:

 

 [2009-05-28 22:42 UTC] ryan dot brothers at gmail dot com
Description:
------------
I believe stream_get_line() should allow the $length parameter to be optional by allowing a $length of -1 that would read the remaining buffer up to either the $ending delimiter or EOF.

Currently if you pass a $length of 0, the $length defaults to PHP_SOCK_CHUNK_SIZE (8192) in ext/standard/streamsfuncs.c.  If you pass a length of -1, a PHP Warning is generated.

Other 'similar' functions that allow length to be optional or -1 are fgets, stream_get_contents, and file_get_contents.

Also, the manual page for stream_get_line() states that this function is the same fgets() except for the handling of the delimiter - but another difference, at least right now, is that the $length parameter is required in stream_get_line(), but optional in fgets().


Reproduce code:
---------------
<?php
$fp = tmpfile();

fwrite($fp, str_repeat('a', 10000));

fseek($fp, 0);
echo strlen(stream_get_line($fp, 0));

fseek($fp, 0);
echo strlen(stream_get_line($fp, -1));

fclose($fp);


Expected result:
----------------
8192
10000

Actual result:
--------------
8192
Warning: stream_get_line(): The maximum allowed length must be greater than or equal to zero

Patches

Add a Patch

Pull Requests

Add a Pull Request

History

AllCommentsChangesGit/SVN commitsRelated reports
 [2014-04-30 22:48 UTC] levim@php.net
-Status: Open +Status: Feedback -Package: Feature/Change Request +Package: Streams related -Operating System: Linux +Operating System: Irrelevant -PHP Version: 5.2.9 +PHP Version: Any
 [2014-04-30 22:48 UTC] levim@php.net
Is this something you are still interested in seeing?
 [2014-05-05 02:03 UTC] ryan dot brothers at gmail dot com
Yes, this would still be useful to me.  I've had to work around it in the meantime.  Thanks for your help.
 [2014-12-30 10:41 UTC] php-bugs at lists dot php dot net
No feedback was provided. The bug is being suspended because
we assume that you are no longer experiencing the problem.
If this is not the case and you are able to provide the
information that was requested earlier, please do so and
change the status of the bug back to "Re-Opened". Thank you.
 [2015-01-03 13:05 UTC] ryan dot brothers at gmail dot com
Yes, I am still interested in this.  It wouldn't let me re-open the bug.
 [2015-01-03 13:27 UTC] nikic@php.net
-Status: No Feedback +Status: Open
 
PHP Copyright © 2001-2017 The PHP Group
All rights reserved.
Last updated: Sun Nov 19 01:31:42 2017 UTC