php.net |  support |  documentation |  report a bug |  advanced search |  search howto |  statistics |  random bug |  login
Bug #46745 Multipart/form-data field names truncated at semicolon in certain cases
Submitted: 2008-12-03 21:54 UTC Modified: 2018-03-11 23:56 UTC
Votes:3
Avg. Score:4.0 ± 1.4
Reproduced:3 of 3 (100.0%)
Same Version:1 (33.3%)
Same OS:1 (33.3%)
From: david at sickmiller dot com Assigned:
Status: Open Package: *General Issues
PHP Version: 5.2.6 OS: Linux
Private report: No CVE-ID: None
View Add Comment Developer Edit
Welcome! If you don't have a Git account, you can't do anything here.
You can add a comment by following this link or if you reported this bug, you can edit this bug over here.
(description)
Block user comment
Status: Assign to:
Package:
Bug Type:
Summary:
From: david at sickmiller dot com
New email:
PHP Version: OS:

 

 [2008-12-03 21:54 UTC] david at sickmiller dot com
Description:
------------
When a form is submitted using multipart-/form-data enctype, PHP will truncate field names if they contain semicolons and certain other characters.  It seems to happen when there is an uneven number of quotation marks that precede the semicolon.

Reproduce code:
---------------
<html><form action="semicolon.php" method="POST" enctype="multipart/form-data">
                <input type="hidden" name="before ; after">
                <input type="hidden" name="&quot; before ; after">
                <input type="hidden" name="' before ; after">
                <input type="hidden" name="' ' before ; after">
                <input type="hidden" name="' &quot; before ; after">
                <input type="hidden" name="&quot; ' before ; after">
                <input type="hidden" name="&quot; &quot; before ; after">
                <input type="hidden" name="&quot; ' ' before ; after">
                <input type="hidden" name="&quot; ' &quot; before ; after">
                <input type="hidden" name="&quot; &quot; ' before ; after">
                <input type="hidden" name="&quot; &quot; &quot; before ; after">
                <input type="hidden" name="' ' ' before ; after">
                <input type="hidden" name="' ' &quot; before ; after">
                <input type="hidden" name="' &quot; ' before ; after">
                <input type="hidden" name="' &quot; &quot; before ; after">
                <input type="submit">
</form><pre><?php
print_r($_POST);
?></pre> </html>


Expected result:
----------------
Array
(
    [before_;_after] => 
    ["_before_;_after] => 
    ['_before_;_after] => 
    ['_'_before_;_after] => 
    ['_"_before_;_after] => 
    ["_'_before_;_after] => 
    ["_"_before_;_after] => 
    ["_'_'_before_;_after] => 
    ["_'_"_before_;_after] => 
    ["_"_'_before_;_after] => 
    ["_"_"_before_;_after] => 
    ['_'_'_before_;_after] => 
    ['_'_"_before_;_after] => 
    ['_"_'_before_;_after] => 
    ['_"_"_before_;_after] => 
)


Actual result:
--------------
Array
(
    [before_;_after] => 
    ["_before_] => 
    ['_before_;_after] => 
    ['_'_before_;_after] => 
    ['_"_before_] => 
    ["_'_before_;_after] => 
    ["_"_before_;_after] => 
    ["_'_'_before_] => 
    ["_'_"_before_;_after] => 
    ["_"_'_before_;_after] => 
    ["_"_"_before_] => 
    ['_'_'_before_;_after] => 
    ['_'_"_before_] => 
    ['_"_'_before_;_after] => 
    ['_"_"_before_;_after] => 
)


Patches

Add a Patch

Pull Requests

Add a Pull Request

History

AllCommentsChangesGit/SVN commitsRelated reports
 [2008-12-09 03:49 UTC] david at sickmiller dot com
For a web application, I have written a PHP file that is a general form handler.  Various different forms all post to this same file, which does a foreach through $_POST and essentially produces a table with each field question and answer.  Some of the forms include file uploads, so I have to use multipart/form-data.

The forms are generated dynamically in a moderately expensive operation and result in HTML like this:
<form>
What's your first name? <input name="What's your name?">
</form>

The questions actually come from different systems, so I don't have the flexibility to change them to remove the non-alphanumeric characters.  And it shouldn't be necessary according to the HTML spec.  It's generally been working, except for the peculiar combinations of apostophes, quotation marks, and semicolons that I inadvertently ran into recently and have documented in this bug.  I checked the header, and it looks like Firefox is correctly submitting the data.

I realize this is a niche case.  How difficult does the fix look?
 [2011-04-08 21:51 UTC] jani@php.net
-Package: Feature/Change Request +Package: *General Issues
 [2018-03-11 23:56 UTC] cmb@php.net
-Type: Feature/Change Request +Type: Bug
 [2018-03-11 23:56 UTC] cmb@php.net
Regardless of whether this is a niche case: the described behavior
would be a bug.
 
PHP Copyright © 2001-2019 The PHP Group
All rights reserved.
Last updated: Thu Sep 19 10:01:26 2019 UTC