php.net |  support |  documentation |  report a bug |  advanced search |  search howto |  statistics |  random bug |  login

go to bug id or search bugs for

Bug #43281 Allow buildconf to pass parameters to cscript
Submitted: 2007-11-13 21:51 UTC Modified: 2007-11-14 01:43 UTC
From: ezyang@php.net Assigned:
Status: Closed Package: *Compile Issues
PHP Version: 5.2CVS-2007-11-13 (CVS) OS: Windows
Private report: No CVE-ID: None
View Add Comment Developer Edit
Welcome! If you don't have a Git account, you can't do anything here.
You can add a comment by following this link or if you reported this bug, you can edit this bug over here.
(description)
Block user comment
Status: Assign to:
Package:
Bug Type:
Summary:
From: ezyang@php.net
New email:
PHP Version: OS:

 

 [2007-11-13 21:51 UTC] ezyang@php.net 
Description:
------------
The buildconf.js script allows for the --add-modules-dir argument to add scan directories for config.w32 files. However, the convenience buildconf.bat script does not pass on configuration directives. This can be fixed by adding %* to the end of the call:

Index: buildconf.bat
===================================================================
RCS file: /repository/php-src/buildconf.bat,v
retrieving revision 1.1
diff -u -r1.1 buildconf.bat
--- buildconf.bat	2 Dec 2003 23:16:47 -0000	1.1
+++ buildconf.bat	13 Nov 2007 21:41:01 -0000
@@ -1,2 +1,2 @@
 @echo off
-cscript /nologo win32\build\buildconf.js
+cscript /nologo win32\build\buildconf.js %*


Reproduce code:
---------------
> cd
C:\php\src\php5
> buildconf --add-modules-dir=C:\php\src\pecl


Expected result:
----------------
Adding C:\php\src\pecl to module search path

Actual result:
--------------
Module not added

Patches

Add a Patch

Pull Requests

Add a Pull Request

History

AllCommentsChangesGit/SVN commitsRelated reports
 [2007-11-14 01:43 UTC] johannes@php.net 
This bug has been fixed in CVS.

Snapshots of the sources are packaged every three hours; this change
will be in the next snapshot. You can grab the snapshot at
http://snaps.php.net/.
 
Thank you for the report, and for helping us make PHP better.
 
PHP Copyright © 2001-2024 The PHP Group
All rights reserved. 		Last updated: Thu May 02 16:01:29 2024 UTC