php.net |  support |  documentation |  report a bug |  advanced search |  search howto |  statistics |  random bug |  login
Bug #43125 Missing space in error messages array min and max
Submitted: 2007-10-29 10:11 UTC Modified: 2007-10-31 13:39 UTC
From: nicholsr@php.net Assigned:
Status: Closed Package: Arrays related
PHP Version: 6CVS-2007-10-29 (CVS) OS: all
Private report: No CVE-ID: None
View Add Comment Developer Edit
Welcome! If you don't have a Git account, you can't do anything here.
You can add a comment by following this link or if you reported this bug, you can edit this bug over here.
(description)
Block user comment
Status: Assign to:
Package:
Bug Type:
Summary:
From: nicholsr@php.net
New email:
PHP Version: OS:

 

 [2007-10-29 10:11 UTC] nicholsr@php.net
Description:
------------
In the array functions min and max implemented in ext/standard/array.c
there are 4 error messages which run together "At" and "least". For example one message is as follows:

"Atleast one value should be passed"

The problem occurs four times in array.c.

I thought twice about raising a bug for something as trivial as thus but when I saw the recent work to sort out the extra periods "." in error messages I realised that it would be appropriate to raise this. 

Once this change has been made the tests I committed for min and max can be altered to require the space. I'm happy to do this. The tests are currently written to pass with or without the space. 

Reproduce code:
---------------
<?php
min();
?>

Expected result:
----------------
Warning: min(): At least one value should be passed in %s on line %d


Actual result:
--------------
Warning: min(): Atleast one value should be passed %s on line %d

Patches

Add a Patch

Pull Requests

Add a Pull Request

History

AllCommentsChangesGit/SVN commitsRelated reports
 [2007-10-31 13:39 UTC] jani@php.net
This bug has been fixed in CVS.

Snapshots of the sources are packaged every three hours; this change
will be in the next snapshot. You can grab the snapshot at
http://snaps.php.net/.
 
Thank you for the report, and for helping us make PHP better.


 
PHP Copyright © 2001-2024 The PHP Group
All rights reserved.
Last updated: Sun May 19 17:01:33 2024 UTC