php.net |  support |  documentation |  report a bug |  advanced search |  search howto |  statistics |  random bug |  login
Request #42446 highlight_(string|file) should use <var>
Submitted: 2007-08-27 15:56 UTC Modified: 2010-12-31 20:42 UTC
From: geoffers at gmail dot com Assigned:
Status: Wont fix Package: *General Issues
PHP Version: 5.2.3 OS: Mac OS 10.4.10
Private report: No CVE-ID: None
View Add Comment Developer Edit
Welcome! If you don't have a Git account, you can't do anything here.
You can add a comment by following this link or if you reported this bug, you can edit this bug over here.
(description)
Block user comment
Status: Assign to:
Package:
Bug Type:
Summary:
From: geoffers at gmail dot com
New email:
PHP Version: OS:

 

 [2007-08-27 15:56 UTC] geoffers at gmail dot com
Description:
------------
The code highlight functions should use <var> for variables in the 
highlighted code.

Reproduce code:
---------------
<?php

highlight_string('$foo');

Expected result:
----------------
<code><span style="color: #000000">
<var>$foo</var></span>
</code>

Actual result:
--------------
<code><span style="color: #000000">
$foo</span>
</code>

Patches

Add a Patch

Pull Requests

Add a Pull Request

History

AllCommentsChangesGit/SVN commitsRelated reports
 [2008-08-25 00:46 UTC] kalle@php.net
The following patch should add <var> to all variables, this does not apply to the curly dollar syntax (${'var'}).

Patch:
http://www.phpfi.com/346971
 [2008-08-25 14:58 UTC] geoffers at gmail dot com
It should certainly apply to the curly dollar syntax too before this bug 
is fixed, though.
 [2010-12-31 20:42 UTC] jani@php.net
-Status: Open +Status: Wont fix -Package: Feature/Change Request +Package: *General Issues
 
PHP Copyright © 2001-2024 The PHP Group
All rights reserved.
Last updated: Sat May 18 17:01:33 2024 UTC