php.net |  support |  documentation |  report a bug |  advanced search |  search howto |  statistics |  random bug |  login

go to bug id or search bugs for

Bug #30455 Livedocs strips HTML comments from source
Submitted: 2004-10-16 07:02 UTC Modified: 2005-02-09 20:47 UTC
Votes:1
Avg. Score:5.0 ± 0.0
Reproduced:1 of 1 (100.0%)
Same Version:1 (100.0%)
Same OS:1 (100.0%)
From: aidan@php.net Assigned: ilia (profile)
Status: Closed Package: Livedocs problem
PHP Version: Irrelevant OS:
Private report: No CVE-ID: None
View Add Comment Developer Edit
Anyone can comment on a bug. Have a simpler test case? Does it work for you on a different platform? Let us know!
Just going to say 'Me too!'? Don't clutter the database with that please !
Your email address:
MUST BE VALID
Solve the problem:
8 + 23 = ?
Subscribe to this entry?

 
 [2004-10-16 07:02 UTC] aidan@php.net 
Description:
------------
Livedocs strips comments from files, which is a problem if you want to add comments to HTML blocks in CDATA.

This is the offending line:

livedocs_funcs.php/213

/* strip comments */
$data = preg_replace('@<!--\s+.*\s-->@Usm', '', $data);

I'm not sure why this needs to be done, but perhaps it can be removed or improved.

Patches

Add a Patch

Pull Requests

Add a Pull Request

History

AllCommentsChangesGit/SVN commitsRelated reports
 [2004-10-16 09:11 UTC] nlopess@php.net 
Yes, those lines can be removed safely.
 [2004-11-13 19:05 UTC] smileaf at ryalth dot com 
stripping comments can be a problem if your wanting to use the w3c recommendation to comment script data out for older browsers. 
I'm experiencing this with php 5.0.2 using xsltprocessor
 [2005-02-09 20:47 UTC] iliaa@php.net 
This bug has been fixed in CVS.

Snapshots of the sources are packaged every three hours; this change
will be in the next snapshot. You can grab the snapshot at
http://snaps.php.net/.
 
Thank you for the report, and for helping us make PHP better.
 
PHP Copyright © 2001-2024 The PHP Group
All rights reserved. 		Last updated: Fri Apr 19 03:01:27 2024 UTC