php.net |  support |  documentation |  report a bug |  advanced search |  search howto |  statistics |  random bug |  login
Request #26525 [patch] needless execution flag in phpbuilddir(/usr/local/lib/php/build)
Submitted: 2003-12-04 15:14 UTC Modified: 2016-04-03 17:43 UTC
Votes:1
Avg. Score:3.0 ± 0.0
Reproduced:0 of 0 (0.0%)
From: sagawa at sohgoh dot net Assigned:
Status: Wont fix Package: *General Issues
PHP Version: 4.3.4 OS: Red Hat Linux 7.2
Private report: No CVE-ID: None
Welcome back! If you're the original bug submitter, here's where you can edit the bug or add additional notes.
If you forgot your password, you can retrieve your password here.
Password:
Status:
Package:
Bug Type:
Summary:
From: sagawa at sohgoh dot net
New email:
PHP Version: OS:

 

 [2003-12-04 15:14 UTC] sagawa at sohgoh dot net
Description:
------------
I've found an issue on default file permission. BUILD_FILES in scripts/Makefile.frags installed with needless excution flag except shtool.

To fix this issue, I made a patch. This patch just change $(INSTALL) to $(INSTALL_DATA) for non executable files.

--- php-4.3.4/scripts/Makefile.frag.orig	Fri Sep 19 14:35:21 2003
+++ php-4.3.4/scripts/Makefile.frag	Fri Dec  5 04:36:38 2003
@@ -6,10 +6,11 @@
 phpincludedir = $(includedir)/php
 phpbuilddir = $(prefix)/lib/php/build
 
-BUILD_FILES = \
+bin_BUILD_FILES = \
+	build/shtool
+data_BUILD_FILES = \
 	scripts/phpize.m4 \
 	build/mkdep.awk \
-	build/shtool \
 	build/scan_makefile_in.awk \
 	Makefile.global \
 	acinclude.m4
@@ -20,7 +21,9 @@
 install-build:
 	@echo "Installing build environment:     $(INSTALL_ROOT)$(phpbuilddir)/"
 	@$(mkinstalldirs) $(INSTALL_ROOT)$(phpbuilddir) $(INSTALL_ROOT)$(bindir) && \
-	(cd $(top_srcdir) && $(INSTALL) $(BUILD_FILES) $(INSTALL_ROOT)$(phpbuilddir))
+	(cd $(top_srcdir) && \
+	$(INSTALL) $(bin_BUILD_FILES) $(INSTALL_ROOT)$(phpbuilddir) && \
+	$(INSTALL_DATA) $(data_BUILD_FILES) $(INSTALL_ROOT)$(phpbuilddir))
 
 HEADER_DIRS = \
 	/ \



Reproduce code:
---------------
./configure && make && make install
and ls -l /usr/local/lib/php/build


Expected result:
----------------
-rw-r--r--    1 root     root         3160 Dec  5 04:43 Makefile.global
-rw-r--r--    1 root     root        46325 Dec  5 04:43 acinclude.m4
-rw-r--r--    1 root     root         2277 Dec  5 04:43 mkdep.awk
-rw-r--r--    1 root     root         2231 Dec  5 04:43 phpize.m4
-rw-r--r--    1 root     root          410 Dec  5 04:43 scan_makefile_in.awk
-rwxr-xr-x    1 root     root        36075 Dec  5 04:43 shtool


Actual result:
--------------
-rwxr-xr-x    1 root     root         3160 Dec  5 04:21 Makefile.global
-rwxr-xr-x    1 root     root        46325 Dec  5 04:21 acinclude.m4
-rwxr-xr-x    1 root     root         2277 Dec  5 04:21 mkdep.awk
-rwxr-xr-x    1 root     root         2231 Dec  5 04:21 phpize.m4
-rwxr-xr-x    1 root     root          410 Dec  5 04:21 scan_makefile_in.awk
-rwxr-xr-x    1 root     root        36075 Dec  5 04:21 shtool


Patches

Pull Requests

History

AllCommentsChangesGit/SVN commitsRelated reports
 [2016-04-03 17:43 UTC] krakjoe@php.net
-Status: Open +Status: Wont fix -Package: Feature/Change Request +Package: *General Issues
 [2016-04-03 17:43 UTC] krakjoe@php.net
As far as I can tell, this is no longer applicable.

Sorry about the wait.
 
PHP Copyright © 2001-2025 The PHP Group
All rights reserved.
Last updated: Sun Jul 06 05:01:37 2025 UTC