php.net |  support |  documentation |  report a bug |  advanced search |  search howto |  statistics |  random bug |  login
Bug #12871 updating build-system to autoconf 2.5x
Submitted: 2001-08-21 06:32 UTC Modified: 2001-08-21 07:46 UTC
From: jan at kneschke dot de Assigned:
Status: Closed Package: Compile Failure
PHP Version: 4.0CVS-2001-08-21 OS:
Private report: No CVE-ID: None
View Add Comment Developer Edit
Welcome! If you don't have a Git account, you can't do anything here.
You can add a comment by following this link or if you reported this bug, you can edit this bug over here.
(description)
Block user comment
Status: Assign to:
Package:
Bug Type:
Summary:
From: jan at kneschke dot de
New email:
PHP Version: OS:

 

 [2001-08-21 06:32 UTC] jan at kneschke dot de
After updating autoconf to 2.52 I've noticed that php is 
working with this autoconf version yet.

Even 'autoupdate' didn't helped to fix it.

I've taken a look at the generated shell code and noticed 
that some 'if-then-else' had an empty else-tree (else fi) 
which caused several unexpected shell exits. 
  These empty else-trees were the result of the following 
commands:
  AC_CHECK_FUNC(yp_get_default_domain,
 [php_no_nsl_checks=yes],[ ])
                         ^^^

That [ ] is the problem. If it is replaced by [] the else 
tree won't be build.

This applies to nearly all macros. The only exception is 
AC_DEFINE which requires a [ ] as third parameter if it is 
set at all.

Another issue was the PHP_SUBST in the acinclude.m4. I 
don't know what the five PHP_SUBST are doing there, but 
they will have to go into the configure.in the satisfy 
autoconf.

(acinclude.m4:930 [somewhere there])

PHP_SUBST(EXT_SUBDIRS)
PHP_SUBST(EXT_STATIC)
PHP_SUBST(EXT_SHARED)
PHP_SUBST(EXT_LIBS)
PHP_SUBST(EXT_LTLIBS)

I've uploaded the corresponding patch to 
http://jan.kneschke.de/projects/phpbugs/php4-20010821.diff

The patch is just a proof of concepts and doesn't fix 
every glitches, but it provides an working example.


Patches

Add a Patch

Pull Requests

Add a Pull Request

History

AllCommentsChangesGit/SVN commitsRelated reports
 [2001-08-21 07:43 UTC] sniper@php.net
These changes seem to have been committed.


 [2001-08-21 07:46 UTC] sas@php.net
Thanks for your comments. We've addressed various issues concerning portability between autoconf-2.13 and the revamped 2.5x tree. The checked-in changes should work on both major autoconf-branches.
 
PHP Copyright © 2001-2021 The PHP Group
All rights reserved.
Last updated: Thu Aug 05 01:01:23 2021 UTC