php.net |  support |  documentation |  report a bug |  advanced search |  search howto |  statistics |  random bug |  login
Bug #10681 Fix for #9698 breaks more than it fixes
Submitted: 2001-05-05 04:40 UTC Modified: 2001-05-19 20:27 UTC
From: kettler at gmx dot net Assigned:
Status: Closed Package: Network related
PHP Version: 4.0 Latest CVS (05/05/2001) OS: Linux
Private report: No CVE-ID: None
View Add Comment Developer Edit
Welcome! If you don't have a Git account, you can't do anything here.
You can add a comment by following this link or if you reported this bug, you can edit this bug over here.
(description)
Block user comment
Status: Assign to:
Package:
Bug Type:
Summary:
From: kettler at gmx dot net
New email:
PHP Version: OS:

 

 [2001-05-05 04:40 UTC] kettler at gmx dot net
<?php
$ipaslong = ip2long("208.247.106.187");
print long2ip($ipaslong)."\n";
print bin2hex(pack("N", $ipaslong))."\n";
?>

That script run with PHP 4.0.5 prints:
208.247.106.187
d0f76abb

whereas with the latest CVS version it prints:
127.255.255.255
7fffffff

That makes that function completely unusable for me (and for others probably too). I have another proposal for fixing bug #9698, and that is implementing %u as a sprintf format specifier to output unsigned longs instead of signed.

This way he could use the following script for his problem (should go onto the ip2long page then):
<?php
$ip = gethostbyname("www.php.net");
$out = sprintf("http://%u/<br>\n", ip2long($ip));
echo $out;
?>

If that fix would be accepted (and the other fix rolled back), I could add %u to sprintf myself and post it here.

Patches

Add a Patch

Pull Requests

Add a Pull Request

History

AllCommentsChangesGit/SVN commitsRelated reports
 [2001-05-06 12:00 UTC] derick@php.net
Sounds ok to me, are you willing to make a patch for this?
 [2001-05-06 13:10 UTC] kettler at gmx dot net
Sure. Here it is:

http://global.team17.com/php4-unsigned.patch

Works for both printf and sprintf. Is there another function I missed?
 [2001-05-09 11:28 UTC] sniper@php.net
Someone who knows that part of PHP better should check the 
patch provided. Marked as to be fixed before 4.0.6

--Jani



 [2001-05-19 20:27 UTC] derick@php.net
I applied the patch, thanks for making it available. The original 'fix'
for bug #9698 has been reversed too. These fixes will be in PHP 4.0.6.

Derick
 
PHP Copyright © 2001-2021 The PHP Group
All rights reserved.
Last updated: Thu Dec 09 14:03:33 2021 UTC