php.net |  support |  documentation |  report a bug |  advanced search |  search howto |  statistics |  random bug |  login
Bug #10400 output_transform_file pointer in sablot.c MUST be initialized to NULL in php_sab
Submitted: 2001-04-19 09:01 UTC Modified: 2001-04-19 11:04 UTC
From: lsorense at csclub dot uwaterloo dot ca Assigned:
Status: Closed Package: Sablotron XSL
PHP Version: 4.0.4pl1 OS: Linux
Private report: No CVE-ID: None
View Add Comment Developer Edit
Welcome! If you don't have a Git account, you can't do anything here.
You can add a comment by following this link or if you reported this bug, you can edit this bug over here.
(description)
Block user comment
Status: Assign to:
Package:
Bug Type:
Summary:
From: lsorense at csclub dot uwaterloo dot ca
New email:
PHP Version: OS:

 

Patches

Add a Patch

Pull Requests

Add a Pull Request

History

AllCommentsChangesGit/SVN commitsRelated reports
 [2001-04-19 10:35 UTC] lsorense at csclub dot uwaterloo dot ca
The two suggested changes fixes the segfaults in apache and the hangs that occour when using xslt_output_begintransform. The hang/segfault occours after each available apache thread has served one request, hence the reson it's seen after 10 to 15 quick reloads, since that's usually how many idle apache threads people have running.

Here is a complete patch for sablot.c:

diff -ur php4-4.0.4.5rc6/ext/sablot/sablot.c php4-4.0.4.5rc6.fixed/ext/sablot/sablot.c
--- php4-4.0.4.5rc6/ext/sablot/sablot.c Sat Mar  3 20:09:36 2001
+++ php4-4.0.4.5rc6.fixed/ext/sablot/sablot.c   Thu Apr 19 08:44:21 2001
@@ -70,7 +70,7 @@
 /* Macro's */

 /* Free macros */
-#define S_FREE(__var) if (__var) efree(__var);
+#define S_FREE(__var) if (__var) {efree(__var);__var = NULL;}
 #define FUNCH_FREE(__var) if (__var) zval_ptr_dtor(&(__var));

 /* ERROR Macros */
@@ -211,6 +211,7 @@
        SABLOTG(processor)    = NULL;
        SABLOTG(errors)       = NULL;
        SABLOTG(errorHandler) = NULL;
+       SABLOTG(output_transform_file) = NULL;
 }

 [2001-04-19 11:04 UTC] sterling@php.net
applied, thanks!
 
PHP Copyright © 2001-2020 The PHP Group
All rights reserved.
Last updated: Sat Jul 11 16:01:24 2020 UTC