|
php.net | support | documentation | report a bug | advanced search | search howto | statistics | random bug | login |
[2010-10-14 06:35 UTC] crrodriguez at opensuse dot org
Description:
------------
Filesystem functions have IMHO the wrong behaviuor on disk-full conditions
Test script:
---------------
<?php
$fp = fopen('/dev/full', 'wb');
var_dump(fwrite($fp, "fail"));
var_dump(fflush($fp));
var_dump(fclose($fp));
Expected result:
----------------
bool(false) and "warning ...No space left on device.. (aka, handle ENOSPC)
bool(false)
bool(true)
Actual result:
--------------
int(0)
bool(true)
bool(true)
PatchesPull RequestsHistoryAllCommentsChangesGit/SVN commits
|
|||||||||||||||||||||||||||
Copyright © 2001-2025 The PHP GroupAll rights reserved. |
Last updated: Wed Nov 05 21:00:02 2025 UTC |
A liltte bit better test case: # dd if=/dev/zero of=/tmp/vfs bs=1024 count=1024 # losetup /dev/loop0 /tmp/vfs # mkfs -t ext2 -m 1 -v /dev/loop0 # mkdir /mnt/vfs # mount -t ext2 /dev/loop0 /mnt/vfs <?php $fp = fopen('/mnt/vfs/foo.txt', 'wb'); var_dump(fwrite($fp, str_repeat("fail", 1024000))); var_dump(fflush($fp)); var_dump(fclose($fp)); ?> int(1003520) bool(true) bool(true) ls -l /mnt/vfs/foo.txt -rw-r--r-- 1 root root 1003520 oct 14 21:43 /mnt/vfs/foo.txt Partial data on disk, no warning or return values hinting the problem.Well, there's the hint that the return value is smaller than strlen(str_repeat("fail", 1024000)) = 4096000. I'm not sure if adding a warning here is appropriate, we try to avoid warnings in correct scripts so that programmers don't have to use "@" to have notice/warning free code. Even if we consider a disk full an exceptional circumstance that merited breaking this guideline, a warning would be of little use; unless the logs are in a separate filesystems, the warning message would not be able to be logged. So: * We can't return false, because a part of the data may have been written and we need to return how much. * A warning would be of no use in most circumstances. Maybe we could return a false+warning if no data has been written, but it seems dangerous because sometimes programmers would be warned of an out-of-disk-space conditional and other times they wouldn't.