|
php.net | support | documentation | report a bug | advanced search | search howto | statistics | random bug | login |
PatchesPull RequestsHistoryAllCommentsChangesGit/SVN commits
[2003-06-06 07:20 UTC] sniper@php.net
[2003-06-29 15:10 UTC] shane@php.net
|
|||||||||||||||||||||||||||||||||||||
Copyright © 2001-2025 The PHP GroupAll rights reserved. |
Last updated: Fri Oct 24 19:00:01 2025 UTC |
I'm using a php with the fastcgi-SAPI for my own webserver lighttpd. While testing various cases I've found a bug in the FastCGI-SAPI in PHP: If no usefull script-filename is sent to the PHP it would send a default error-page with "No input file specified." and status 404. After sending this messsage the module is shutdown without finishing the FastCGI request. This results in a missing FCGI_REQUEST_END packet and is against the FastCGI spec. I don't know if the FCGX_Finished_r() should be called before or after module_shutdown(). Before actually works fine. Index: cgi_main.c =================================================================== RCS file: /repository/php4/sapi/cgi/cgi_main.c,v retrieving revision 1.190.2.37 diff -u -r1.190.2.37 cgi_main.c --- cgi_main.c 31 May 2003 17:02:01 -0000 1.190.2.37 +++ cgi_main.c 4 Jun 2003 07:19:12 -0000 @@ -1487,6 +1487,9 @@ SG(sapi_headers).http_response_code = 404; PUTS("No input file specified.\n"); php_request_shutdown((void *) 0); +#ifdef PHP_FASTCGI + if (fastcgi) FCGX_Finish_r(&request); +#endif php_module_shutdown(TSRMLS_C); return FAILURE; }