php.net |  support |  documentation |  report a bug |  advanced search |  search howto |  statistics |  random bug |  login

go to bug id or search bugs for

Doc Bug #80520 Uploading anonymous documentation edits
Submitted: 2020-12-15 18:19 UTC Modified: 2021-01-01 10:00 UTC
From: craig at craigfrancis dot co dot uk Assigned:
Status: Closed Package: MySQLi related
PHP Version: Irrelevant OS:
Private report: No CVE-ID: None
View Developer Edit
Welcome back! If you're the original bug submitter, here's where you can edit the bug or add additional notes.
If you forgot your password, you can retrieve your password here.
Password:
Status:
Package:
Bug Type:
Summary:
From: craig at craigfrancis dot co dot uk
New email:
PHP Version: OS:

 

 [2020-12-15 18:19 UTC] craig at craigfrancis dot co dot uk 
Description:
------------
---
From manual page: https://php.net/mysqli.examples-basic
---

A week ago I edited the "MySQLi extension basic examples" page, and that seems to have saved, as future edits mention "File modified by anonymous #1457"

But how do those changes get committed, checked, and uploaded to the php.net website?

For reference, I've changed the SQL to use parameterised queries (bind_param), as it's bad practice to concatenate values into SQL string, and the output needs to use HTML encoding (considering the HTML context).

Patches

Pull Requests

History

AllCommentsChangesGit/SVN commitsRelated reports
 [2020-12-15 18:26 UTC] cmb@php.net 
> But how do those changes get committed, checked, and uploaded to
> the php.net website?

Someone who is fully pain resistant would need to review on
edit.php.net.  Please provide future change requests as PRs
against <https://github.com/php/doc-en> where the review process
is so much more productive.
 [2020-12-16 15:26 UTC] craig at craigfrancis dot co dot uk 
Thanks @cmb, that's really good to know.

I've created 2 PRs; the first is to use parameterised queries, the second introduces HTML and URL encoding (considering the output is HTML).

https://github.com/php/doc-en/pull/278
https://github.com/php/doc-en/pull/279

As to the "Edit" link on the PHP documentation pages, is it worth changing this to the GitHub repo?

As in, rather than a link to:

https://edit.php.net/?project=PHP&perm=en/mysqli.examples-basic.php

Change it to:

https://github.com/php/doc-en/blob/master/reference/mysqli/examples.xml

And hope that anyone following the link will know how to create a PR?
 [2021-01-01 10:00 UTC] craig at craigfrancis dot co dot uk
-Status: Open +Status: Closed
 [2021-01-01 10:00 UTC] craig at craigfrancis dot co dot uk 
Closed, because page has been removed
 
PHP Copyright © 2001-2025 The PHP Group
All rights reserved. 		Last updated: Thu Jul 03 08:01:34 2025 UTC