Description:
------------
When running on Windows with PHP_INI_SCAN_DIR set, php will either crash or misreport information when running php --ini. This did not happen on pre-7.2 versions.

php_init_config() calls PHPAPI php_scandir and the directory list returned has corrupted dirent->d_name values. This either causes an access violation when calling strrchr from the runtime, or results in any ini file in the directory being correctly reported, not reported or reported multiple times.

The crashes seem to happen more frequently when the target folder contains 200 + entries, although the misreported data can happen with a single entry.

 

Test script:
---------------
// The crashes happen more frequently on a debug build, so:
configure --disable-all --enable-cli --enable-debug --disable-zts

// Using my temp folder which has lots of stuff in it
run: SET PHP_INI_SCAN_DIR=C:\Users\John\AppData\Local\Temp

add an .ini file to the chosen folder (for example 'scan-dir.ini'). It isn't actually needed but it helps show the misreported data.


run: php.exe --ini

Expected result:
----------------
Configuration File (php.ini) Path: C:\WINDOWS
Loaded Configuration File:         (none)
Scan for additional .ini files in: C:\Users\John\AppData\Local\Temp
Additional .ini files parsed:      C:\Users\John\AppData\Local\Temp\scan-dir.ini

Actual result:
--------------
A crash:

>	vcruntime140d.dll!strrchr(const char * string, int ch) Line 203	C	Non-user code. Symbols loaded.
 	php7_debug.dll!php_init_config() Line 687	C	Symbols loaded.
 	php7_debug.dll!php_module_startup(_sapi_module_struct * sf, _zend_module_entry * additional_modules, unsigned int num_additional_modules) Line 2250	C	Symbols loaded.
 	php.exe!php_cli_startup(_sapi_module_struct * sapi_module) Line 431	C	Symbols loaded.
 	php.exe!main(int argc, char * * argv) Line 1371	C	Symbols loaded.
 	[External Code]		Annotated Frame

Unhandled exception thrown: read access violation.
**string** was 0x193A4B4A600. occurred

-----
Or missing data:

Configuration File (php.ini) Path: C:\WINDOWS
Loaded Configuration File:         (none)
Scan for additional .ini files in: C:\Users\John\AppData\Local\Temp
Additional .ini files parsed:      (none

-----
Or duplicate data:

Configuration File (php.ini) Path: C:\WINDOWS
Loaded Configuration File:         (none)
Scan for additional .ini files in: C:\Users\John\AppData\Local\Temp
Additional .ini files parsed:      C:\Users\John\AppData\Local\Temp\scan-dir.ini,
C:\Users\John\AppData\Local\Temp\scan-dir.ini,
C:\Users\John\AppData\Local\Temp\scan-dir.ini