php.net |  support |  documentation |  report a bug |  advanced search |  search howto |  statistics |  random bug |  login

go to bug id or search bugs for

Bug #74396 Many compilation errors
Submitted: 2017-04-09 11:47 UTC Modified: 2020-03-13 13:23 UTC
Votes:11
Avg. Score:4.3 ± 0.9
Reproduced:10 of 10 (100.0%)
Same Version:6 (60.0%)
Same OS:8 (80.0%)
From: anon dot amish at gmail dot com Assigned:
Status: Suspended Package: PAM (PECL)
PHP Version: 7.1.3 OS: Linux
Private report: No CVE-ID: None
View Developer Edit
Welcome back! If you're the original bug submitter, here's where you can edit the bug or add additional notes.
If you forgot your password, you can retrieve your password here.
Password:
Status:
Package:
Bug Type:
Summary:
From: anon dot amish at gmail dot com
New email:
PHP Version: OS:

 

 [2017-04-09 11:47 UTC] anon dot amish at gmail dot com 
Description:
------------
Trying to compile the code gives lots of compilation errors

Some errors:

/home/devel/AUR/php-pam/src/pam-1.0.3/pam.c: In function ‘zif_pam_auth’:
/home/devel/AUR/php-pam/src/pam-1.0.3/pam.c:251:36: error: macro "ZVAL_STRING" passed 3 arguments, but takes just 2
    ZVAL_STRING(status, error_msg, 0);
                                    ^
...
/home/devel/AUR/php-pam/src/pam-1.0.3/pam.c:256:6: error: too many arguments to function ‘zend_hash_find’
  if (zend_hash_find(&EG(symbol_table), "_SERVER", sizeof("_SERVER"), (void **)&server) == SUCCESS && Z_TYPE_PP(server) == IS_ARRAY) {




Expected result:
----------------
Source should compile successfully

Actual result:
--------------
Compilation fails

Patches

zend.patch (last revision 2017-04-09 11:47 UTC by anon dot amish at gmail dot com)

Pull Requests

History

AllCommentsChangesGit/SVN commitsRelated reports
 [2017-04-10 13:06 UTC] anon dot amish at gmail dot com 
Patch I uploaded seems to be working correctly.

However, running small command like this, causes coredump

php -r "pam_auth('someuser','somepassword');"

coredump does not seem to be related to my patch as it happens before code reaches any of my changes (in pam_start)


But same command works if I disable optimization with CFLAGS -O0 .

Do not know how disabling optimization solves the issue?

Hope project maintainer can figure it out as I could not.
 [2017-04-11 14:11 UTC] cmb@php.net 
> Hope project maintainer can figure it out as I could not.

It seems the extension is unmaintained, though, see
<http://svn.php.net/viewvc/pecl/pam/trunk/>.
 [2017-04-11 14:32 UTC] anon dot amish at gmail dot com 
Yes I noticed that the maintainer (@mikl) has 4 packages under him where in 3 of those he is sole maintainer. Last he was active in any of those 3 packages was in 2009 (so almost 8years)

https://pecl.php.net/user/mikl

pam is well known authentication method. So I was wondering why it is not being maintained.

Based on the statistics almost 10000 downloads happen per your for this package.
https://pecl.php.net/package-stats.php?pid=667&rid=&cid=1

What is the procedure if there is no maintainer?
 [2017-05-10 07:16 UTC] anon dot amish at gmail dot com 
Somebody please apply the attached patch to:
http://svn.php.net/viewvc/pecl/pam/trunk/

Or let me know how to create pull request?

Thank you.
 [2017-06-26 09:01 UTC] cmb@php.net 
Related To: Bug #74812
 [2018-11-25 16:08 UTC] cmb@php.net 
> What is the procedure if there is no maintainer?

You can apply for a PECL account[1], and request to be added as
maintainer for PECL/PAM.

[1] <https://pecl.php.net/account-request.php>
 [2018-11-27 05:00 UTC] anon dot amish at gmail dot com 
I have fixed it at github and also added new features. (But needs PHP7)

https://github.com/amishmm/php-pam
 [2020-02-11 21:17 UTC] p dot mandon at laposte dot net 
I also ahve this problem on recent linux distro, based on the excellent
work of amish ( and also openmediavault) i purpose to :
package it in pecl format, with updated sources and readme to correctly
explain what is needed to be done to have a functionnal PAM under
version PHP7+, and a simple test script to validate all functions
included in 'readme'.
I think this module is very interresting and must be avaible to php7
'simply'.
before asking pecl account i've read it would be simple that i ask if my
proposition is correct.
thank you
 [2020-03-13 13:23 UTC] cmb@php.net
-Status: Open +Status: Suspended
 [2020-03-13 13:23 UTC] cmb@php.net 
The PAM package had no new release for more than ten years, and
has to be considered unmaintained.  If anybody is interesting in
taking over maintainership[1], they are welcome.  For the time
being, I'm suspending this ticket.

[1] <https://pecl.php.net/takeover.php>
 
PHP Copyright © 2001-2024 The PHP Group
All rights reserved. 		Last updated: Sun Nov 24 22:01:33 2024 UTC