|
php.net | support | documentation | report a bug | advanced search | search howto | statistics | random bug | login |
[2017-01-14 11:37 UTC] ryan dot brothers at gmail dot com
Description:
------------
I am running into an intermittent issue when using ldap_mod_replace with opcache enabled over php-fpm. Sometimes the script succeeds and other times, the same script fails or has a segfault.
It's tricky to simulate, but I believe the below script shows the issue. The script returns the error "Can't contact LDAP server" correctly on the first run, but later runs sometime return the error "Encoding error" or a segfault. I was expecting the error message to be the same on each run.
The issue only occurs with opcache enabled. When opcache is disabled, the error message is the same on each run.
The issue also only happens over php-fpm. When I run the script over CLI, the error message is the same on each run.
I am running PHP 7.1 on CentOS 7, but the problem appears to have started in PHP 7 as PHP 5.6.29 seems ok.
Test script:
---------------
<?php
define('AAA', 1);
error_reporting(E_ALL);
$ldap = ldap_connect('127.0.0.1', 5000);
ldap_mod_replace($ldap, null, array(
'lockoutTime' => array(0),
));
ldap_close($ldap);
Expected result:
----------------
Warning: ldap_mod_replace(): Modify: Can't contact LDAP server in /var/www/html/ldap.php on line 9
Actual result:
--------------
Sometimes:
Warning: ldap_mod_replace(): Modify: Can't contact LDAP server in /var/www/html/ldap.php on line 9
Other times:
Warning: ldap_mod_replace(): Modify: Encoding error in /var/www/html/ldap.php on line 9
or a segfault
PatchesPull RequestsHistoryAllCommentsChangesGit/SVN commits
|
|||||||||||||||||||||||||||
Copyright © 2001-2025 The PHP GroupAll rights reserved. |
Last updated: Sun Nov 02 20:00:01 2025 UTC |
I think it is because ldap edit the const array argument in place, please try with the following patch: diff --git a/ext/ldap/ldap.c b/ext/ldap/ldap.c index 4068384..5c1b6da 100644 --- a/ext/ldap/ldap.c +++ b/ext/ldap/ldap.c @@ -1427,7 +1427,7 @@ static void php_ldap_do_modify(INTERNAL_FUNCTION_PARAMETERS, int oper) zend_ulong index; int is_full_add=0; /* flag for full add operation so ldap_mod_add can be put back into oper, gerrit THomson */ - if (zend_parse_parameters(ZEND_NUM_ARGS(), "rsa", &link, &dn, &dn_len, &entry) != SUCCESS) { + if (zend_parse_parameters(ZEND_NUM_ARGS(), "rsa/", &link, &dn, &dn_len, &entry) != SUCCESS) { return; } thankslaruence - thanks, I'm still seeing the segfault or various errors such as "Invalid syntax" or "Encoding error" when repeatedly calling the script with your patch. It always works the first time, but not later runs. Using opcache.protect_memory, you should be able to reproduce the segfault in CLI without having a working LDAP server: php -n -d zend_extension=opcache.so -d opcache.enable_cli=1 -d opcache.protect_memory=1 ldap.php <?php define('AAA', 1); error_reporting(E_ALL); $ldap = ldap_connect('127.0.0.1', 5000); ldap_mod_replace($ldap, null, array( 'lockoutTime' => array(0), )); ldap_close($ldap);laruence - Thank you for the quick fix. Could you please also check the ldap_modify_batch function? I think it's the same problem there with the segfault. A reproduce script is: <?php $ldap = ldap_connect('127.0.0.1', 5000); ldap_modify_batch($ldap, null, array()); ldap_close($ldap);