php.net |  support |  documentation |  report a bug |  advanced search |  search howto |  statistics |  random bug |  login

go to bug id or search bugs for

Request #72078 Menu option to reject files and patchs from Patchs for review
Submitted: 2016-04-22 15:26 UTC Modified: 2021-08-09 13:39 UTC
Votes:4
Avg. Score:5.0 ± 0.0
Reproduced:3 of 3 (100.0%)
Same Version:2 (66.7%)
Same OS:2 (66.7%)
From: andrebacci dot listas at gmail dot com Assigned: sergey (profile)
Status: Closed Package: Online Doc Editor problem
PHP Version: Irrelevant OS:
Private report: No CVE-ID: None
View Developer Edit
Welcome back! If you're the original bug submitter, here's where you can edit the bug or add additional notes.
If you forgot your password, you can retrieve your password here.
Password:
Status:
Package:
Bug Type:
Summary:
From: andrebacci dot listas at gmail dot com
New email:
PHP Version: OS:

 

 [2016-04-22 15:26 UTC] andrebacci dot listas at gmail dot com 
Description:
------------
Create an menu option to directly reject patchs from there.

It's useful for workflows that downloads and commits patchs outside OE, and for some situations where right clicking a file in "Patchs for review" > "Edit in a new tab" don't works a second time, and so no option to reject is presented.

Expected result:
----------------
Way to reject entire patchs or individual files can be done directly.

Actual result:
--------------
It's necessary request "Edit in a new tab" for each file to reject. Sometimes this option doesn't works, failing silently.

Patches

Pull Requests

History

AllCommentsChangesGit/SVN commitsRelated reports
 [2016-04-25 01:52 UTC] ae@php.net 
Also, add a option to delete files and folders from "Work in progress".

Maybe a option to commit files directly from Wip, without need to create a patch and them commit from "Patchs from review".
 [2021-08-03 12:14 UTC] cmb@php.net
-Status: Open +Status: Feedback -Assigned To: +Assigned To: cmb
 [2021-08-03 12:14 UTC] cmb@php.net 
There is no longer the need to use edit.php.net (maybe except for
translators); instead, submitting pull requests[1] is preferred
now.  So is this still an issue for you?

[1] <https://github.com/php/doc-en/pulls>
 [2021-08-03 13:57 UTC] ae@php.net 
It's not a issue anymore. The pt_BR translation abandoned edit.php.net.

We only need to block pt_BR from being used there.
 [2021-08-03 14:09 UTC] cmb@php.net
-Status: Feedback +Status: Open -Assigned To: cmb +Assigned To: sergey
 [2021-08-03 14:09 UTC] cmb@php.net 
> We only need to block pt_BR from being used there.

That shouldn't be a real issue, since only users with a php.net
account have access to the online editor, and apparently no new
patches have been submitted this year (there are a couple of old
patches lying around, though).

Anyhow, maybe Sergey can disable the pt_BR translation on
edit.php.net?
 [2021-08-09 06:49 UTC] sergey@php.net 
Disabled pt_BR translation
 [2021-08-09 13:39 UTC] sergey@php.net
-Status: Assigned +Status: Closed
 
PHP Copyright © 2001-2025 The PHP Group
All rights reserved. 		Last updated: Wed Jul 02 07:01:33 2025 UTC