php.net |  support |  documentation |  report a bug |  advanced search |  search howto |  statistics |  random bug |  login

go to bug id or search bugs for

Request #71379 Add support for Apache 2.4 mod_proxy_balancer to FPM
Submitted: 2016-01-15 03:54 UTC Modified: 2023-10-08 13:06 UTC
Votes:1
Avg. Score:3.0 ± 0.0
Reproduced:0 of 0 (0.0%)
From: matt at haught dot org Assigned: bukka (profile)
Status: Assigned Package: FPM related
PHP Version: 7.0.2 OS: FreeBSD
Private report: No CVE-ID: None
View Developer Edit
Welcome back! If you're the original bug submitter, here's where you can edit the bug or add additional notes.
If you forgot your password, you can retrieve your password here.
Password:
Status:
Package:
Bug Type:
Summary:
From: matt at haught dot org
New email:
PHP Version: OS:

 

 [2016-01-15 03:54 UTC] matt at haught dot org 
Description:
------------
When using Apache 2.4's mod_proxy_balancer and fpm, Apache does not prefix the request with "proxy:fcgi://". As a result, the request from the balancer is never caught to have its query string cut out. Any request with a ? will then fail.

The attached patch simply moves the existing query string cutting out of the "proxy:fcgi://" block and into its own. It only will make this action if env_server_software equals Apache rather the just those requests with the "proxy:fcgi://" prefix.

Patches

add-balancer-support-v2 (last revision 2016-01-15 04:01 UTC by matt at haught dot org)
add-balancer-support (last revision 2016-01-15 03:59 UTC by matt at haught dot org)

Pull Requests

History

AllCommentsChangesGit/SVN commitsRelated reports
 [2023-10-08 13:06 UTC] bukka@php.net 
I have been looking into this and I think it makes sense to do it this way. I initially had this issue noted as a bug as we have got balancer logic but that no longer works due to the correctly mentioned fact that it is no longer prefixed with proxy:balancer:// which was the case before. But more I look into it, more I think it should probably go just to master (next version).

The thing is that there might be potential issue with SERVER_SOFTWARE that might be used for some potentially old Apache setups but not sure if that's really likely. But to be on the safe side it makes more sense to keep it as a feature request.

I will try to do some more looking and experimenting before creating complete patch with a test.
 [2023-10-08 13:06 UTC] bukka@php.net
-Assigned To: +Assigned To: bukka
 
PHP Copyright © 2001-2024 The PHP Group
All rights reserved. 		Last updated: Sat Nov 23 11:01:28 2024 UTC