php.net |  support |  documentation |  report a bug |  advanced search |  search howto |  statistics |  random bug |  login

go to bug id or search bugs for

Bug #68786 Missing check
Submitted: 2015-01-10 10:19 UTC Modified: 2021-10-15 17:21 UTC
From: bugreports at internot dot info Assigned:
Status: Open Package: Scripting Engine problem
PHP Version: master-Git-2015-01-10 (Git) OS: Linux Ubuntu 14.04
Private report: No CVE-ID: None
View Developer Edit
Welcome back! If you're the original bug submitter, here's where you can edit the bug or add additional notes.
If you forgot your password, you can retrieve your password here.
Password:
Status:
Package:
Bug Type:
Summary:
From: bugreports at internot dot info
New email:
PHP Version: OS:

 

 [2015-01-10 10:19 UTC] bugreports at internot dot info 
Description:
------------
Hi,

In Zend/zend_signal.c:

Zend/zend_signal.c:306:                 sigaction(zend_sigs[x], NULL, &sa);
Zend/zend_signal.c-307-                 if (sa.sa_sigaction != zend_signal_handler_defer) {
Zend/zend_signal.c-308-                         zend_error(E_CORE_WARNING, "zend_signal: handler was replaced for signal (%d) after startup", zend_sigs[x]);
Zend/zend_signal.c-309-                 }


The return value of "sigaction(zend_sigs[x], NULL, &sa)" is not checked, as it is everywhere else it is used.

It should be checked here, too.


Thanks,

Patches

Pull Requests

History

AllCommentsChangesGit/SVN commitsRelated reports
 [2021-10-15 17:21 UTC] cmb@php.net
-Package: *General Issues +Package: Scripting Engine problem
 [2021-10-15 17:21 UTC] cmb@php.net 
While It might be okay not to check the return value on getting[1]
(it is certainly important on setting), it might still be prudent
to do so.

[1] <https://github.com/php/php-src/blob/php-7.4.24/Zend/zend_signal.c#L348>
 
PHP Copyright © 2001-2024 The PHP Group
All rights reserved. 		Last updated: Mon Dec 30 17:01:29 2024 UTC