php.net |  support |  documentation |  report a bug |  advanced search |  search howto |  statistics |  random bug |  login
Doc Bug #67549 $peg argument not documented
Submitted: 2014-07-01 11:42 UTC Modified: 2021-06-07 09:44 UTC
From: giso at connectholland dot nl Assigned: alan_k (profile)
Status: Closed Package: svn (PECL)
PHP Version: 5.5.14 OS:
Private report: No CVE-ID: None
Welcome back! If you're the original bug submitter, here's where you can edit the bug or add additional notes.
If you forgot your password, you can retrieve your password here.
Password:
Status:
Package:
Bug Type:
Summary:
From: giso at connectholland dot nl
New email:
PHP Version: OS:

 

 [2014-07-01 11:42 UTC] giso at connectholland dot nl
Description:
------------
---
From manual page: http://www.php.net/function.svn-ls
---

The $peg argument listed in the function call description is not documented


Patches

Pull Requests

History

AllCommentsChangesGit/SVN commitsRelated reports
 [2018-02-24 17:16 UTC] cmb@php.net
From looking at the sources, the $peg parameter appears to be
unused.
 [2021-05-31 13:55 UTC] cmb@php.net
-Assigned To: +Assigned To: alan_k
 [2021-05-31 13:55 UTC] cmb@php.net
Alan, can you confirm that this parameter is indeed unused?
 [2021-06-01 02:27 UTC] alan at roojs dot com
Yes, 

The peg option was removed here - It's probably only in there for BC - the argument is ignored
http://svn.php.net/viewvc/pecl/svn/trunk/svn.c?r1=315262&r2=317303
 [2021-06-07 03:09 UTC] alan_k@php.net
-Assigned To: alan_k +Assigned To: cmb
 [2021-06-07 03:09 UTC] alan_k@php.net
Committing to SVN seems to not work anymore - here's the patch to fix this.


--- trunk/svn.c	(revision 352318)
+++ trunk/svn.c	(working copy)
@@ -961,7 +961,7 @@
 }
 
 
-/* {{{ proto array svn_ls(string repository_url [, int revision [, bool recurse [, bool peg]]])
+/* {{{ proto array svn_ls(string repository_url [, int revision [, bool recurse ]])
 	Returns a list of a directory in a working copy or repository, optionally at revision_no. */
 PHP_FUNCTION(svn_ls)
 {
@@ -968,7 +968,7 @@
 	const char *repos_url = NULL;
 	const char *utf8_repos_url = NULL;
 	long repos_url_len;
-	zend_bool recurse = 0, peg = 0;
+	zend_bool recurse = 0;
 	svn_error_t *err;
 	svn_opt_revision_t revision = { 0 };
 	apr_hash_t *dirents;
@@ -977,8 +977,8 @@
 	const char *true_path;
 	apr_hash_index_t *hi;
 
-	if (zend_parse_parameters(ZEND_NUM_ARGS() TSRMLS_CC, "s|lbb",
-			&repos_url, &repos_url_len, &revision.value.number, &recurse, &peg) == FAILURE) {
+	if (zend_parse_parameters(ZEND_NUM_ARGS() TSRMLS_CC, "s|lb",
+			&repos_url, &repos_url_len, &revision.value.number, &recurse) == FAILURE) {
 		return;
 	}
 	PHP_SVN_INIT_CLIENT();
 [2021-06-07 09:41 UTC] cmb@php.net
Several SVN repos have been moved to Github a while ago.  I just
invited you to <https://github.com/php/pecl-tools-svn>.  I'm
uncomfortable with working on that repo, because I cannot even
build on Windows.
 [2021-06-07 09:44 UTC] cmb@php.net
-Assigned To: cmb +Assigned To: alan_k
 [2021-06-08 03:11 UTC] git@php.net
Automatic comment on behalf of roojs
Revision: https://github.com/php/pecl-tools-svn/commit/0537c89ab973edf0851d03249c18d8b0569f6e9d
Log: fix #67549 - remove unused peg argument
 [2021-06-08 03:11 UTC] git@php.net
-Status: Assigned +Status: Closed
 
PHP Copyright © 2001-2025 The PHP Group
All rights reserved.
Last updated: Fri Jul 04 17:01:35 2025 UTC