php.net |  support |  documentation |  report a bug |  advanced search |  search howto |  statistics |  random bug |  login

go to bug id or search bugs for

Request #67106 split main fpm config
Submitted: 2014-04-22 02:34 UTC Modified: 2014-12-14 13:25 UTC
From: glen at delfi dot ee Assigned: remi (profile)
Status: Closed Package: FPM related
PHP Version: master OS:
Private report: No CVE-ID: None
View Developer Edit
Welcome back! If you're the original bug submitter, here's where you can edit the bug or add additional notes.
If you forgot your password, you can retrieve your password here.
Password:
Status:
Package:
Bug Type:
Summary:
From: glen at delfi dot ee
New email:
PHP Version: OS:

 

 [2014-04-22 02:34 UTC] glen at delfi dot ee 
Description:
------------
hi

i would like main php fpm config split, this eases distribution packaging and makes easier to create new pools for the end users (cp www.conf my-new-pool.conf)

i've done so in my distribution, and been happy with it

i understood from https://github.com/php/php-src/blob/master/README.GIT-RULES that there must be always a bugreport, like this. right?

is there interest in that? if so, then should i create github pull requests to all 3 branches (master, 5.4, 5.5)?

you can see the existing patches in my distribution:
- 5.3 https://github.com/pld-linux/php/blob/auto/th/php-5.3.28-4/fpm-conf-split.patch
- 5.5 https://github.com/pld-linux/php/blob/auto/th/php55-5.5.10-3/fpm-conf-split.patch
- 5.6 prepared, but not yet published

Patches

Pull Requests

Pull requests:

History

AllCommentsChangesGit/SVN commitsRelated reports
 [2014-06-23 11:56 UTC] tyrael@php.net
-PHP Version: 5.6.0beta1 +PHP Version: master
 [2014-06-23 11:56 UTC] tyrael@php.net 
I don't think that we want to change this in the stable branches, and 5.6.0 is already in the feature freeze, but feel free to bring this up on the internal mailing lists for discussion.
As you mentioned this is mostly useful for distributations, and they are already solved this for themselfs, so I'm not even sure they would use it anyways.

ps: I think that one Pull Request against master would be enough to demonstrate the change.
 [2014-12-14 13:24 UTC] remi@php.net 
Automatic comment on behalf of remi
Revision: http://git.php.net/?p=php-src.git;a=commit;h=855d2966385755435b65d77e1c0dfda17555eab9
Log: Fix bug #67106 split main fpm config
 [2014-12-14 13:24 UTC] remi@php.net
-Status: Open +Status: Closed
 [2014-12-14 13:25 UTC] remi@php.net
-Assigned To: +Assigned To: remi
 [2014-12-14 13:25 UTC] remi@php.net 
PR#903 merged in http://git.php.net/?p=php-src.git;a=commitdiff;h=9f189dd29075589aeb3c88c4e2860d6ae0730f27
 [2014-12-15 19:00 UTC] ab@php.net 
Automatic comment on behalf of remi
Revision: http://git.php.net/?p=php-src.git;a=commit;h=855d2966385755435b65d77e1c0dfda17555eab9
Log: Fix bug #67106 split main fpm config
 [2016-07-20 11:40 UTC] davey@php.net 
Automatic comment on behalf of remi
Revision: http://git.php.net/?p=php-src.git;a=commit;h=855d2966385755435b65d77e1c0dfda17555eab9
Log: Fix bug #67106 split main fpm config
 
PHP Copyright © 2001-2024 The PHP Group
All rights reserved. 		Last updated: Sun Nov 24 21:01:35 2024 UTC