php.net |  support |  documentation |  report a bug |  advanced search |  search howto |  statistics |  random bug |  login

go to bug id or search bugs for

Bug #65047 Test skip on client / server version
Submitted: 2013-06-17 13:11 UTC Modified: -
From: remi@php.net Assigned:
Status: Closed Package: PostgreSQL related
PHP Version: 5.4.16 OS: GNU/Linux
Private report: No CVE-ID: None
View Developer Edit
Welcome back! If you're the original bug submitter, here's where you can edit the bug or add additional notes.
If you forgot your password, you can retrieve your password here.
Password:
Status:
Package:
Bug Type:
Summary:
From: remi@php.net
New email:
PHP Version: OS:

 

 [2013-06-17 13:11 UTC] remi@php.net 
Description:
------------
Hi,

Running the php test suite, using a client library version 8.4.13 (RHEL-6) against a server running version 9.2.4 (RHEL-6 + RHSCL 1.0beta) reports some failures

/tmp/php-5.4.16/ext/pgsql/tests/08escape.phpt
/tmp/php-5.4.16/ext/pgsql/tests/10pg_convert_85.phpt
/tmp/php-5.4.16/ext/pgsql/tests/12pg_insert_85.phpt
/tmp/php-5.4.16/ext/pgsql/tests/14pg_update_85.phpt
/tmp/php-5.4.16/ext/pgsql/tests/18pg_escape_bytea.phpt
/tmp/php-5.4.16/ext/pgsql/tests/bug37100_85.phpt

/tmp/php-5.4.16/ext/pdo_pgsql/tests/bug46274.phpt
/tmp/php-5.4.16/ext/pdo_pgsql/tests/bug46274_2.phpt

For example PQunescapeBytea function is a pure client side function. So result depends on the client version, not on the server version.

Proposal, keep (or add where is missing):
skip_server_version('8.5dev', '<');

And add:
skip_client_version('8.5dev', '<');

I agree, using a 8.4 client to access a 9.2 server is something which should be avoid...


What is your thoughts ?
(I prefer asking before committing something perhaps stupid)

Patches

Pull Requests

History

AllCommentsChangesGit/SVN commitsRelated reports
 [2013-06-17 14:09 UTC] remi@php.net 
On a opposite side pgsql/tests/bug37100.phpt could use
skip_client_version('8.5dev', '>=');

It will be run and will succeed with client version 8.4
 [2013-06-19 09:54 UTC] mbeccati@php.net 
Automatic comment on behalf of mbeccati
Revision: http://git.php.net/?p=php-src.git;a=commit;h=c666239265048abd3cc0b2c48493a5db1eacc28e
Log: Fixed bug #65047 (Test skip on client / server version)
 [2013-06-19 09:54 UTC] mbeccati@php.net
-Status: Open +Status: Closed
 [2014-10-07 23:18 UTC] stas@php.net 
Automatic comment on behalf of mbeccati
Revision: http://git.php.net/?p=php-src-security.git;a=commit;h=c666239265048abd3cc0b2c48493a5db1eacc28e
Log: Fixed bug #65047 (Test skip on client / server version)
 [2014-10-07 23:29 UTC] stas@php.net 
Automatic comment on behalf of mbeccati
Revision: http://git.php.net/?p=php-src-security.git;a=commit;h=c666239265048abd3cc0b2c48493a5db1eacc28e
Log: Fixed bug #65047 (Test skip on client / server version)
 
PHP Copyright © 2001-2025 The PHP Group
All rights reserved. 		Last updated: Wed Apr 23 21:01:27 2025 UTC