php.net |  support |  documentation |  report a bug |  advanced search |  search howto |  statistics |  random bug |  login
Bug #64417 BC break: ArrayAccess::&offsetGet() in a trait causes fatal error.
Submitted: 2013-03-12 22:39 UTC Modified: 2013-03-19 09:27 UTC
Votes:1
Avg. Score:5.0 ± 0.0
Reproduced:0 of 0 (0.0%)
From: me at fixxxer dot me Assigned: dmitry (profile)
Status: Closed Package: Scripting Engine problem
PHP Version: 5.4Git-2013-03-12 (snap) OS: any
Private report: No CVE-ID: None
Welcome back! If you're the original bug submitter, here's where you can edit the bug or add additional notes.
If you forgot your password, you can retrieve your password here.
Password:
Status:
Package:
Bug Type:
Summary:
From: me at fixxxer dot me
New email:
PHP Version: OS:

 

 [2013-03-12 22:39 UTC] me at fixxxer dot me
Description:
------------
http://www.php.net/manual/en/arrayaccess.offsetget.php

"While direct modification triggers a call to ArrayAccess::offsetSet(), indirect 
modification triggers a call to ArrayAccess::offsetGet(). In that case, the 
implementation of ArrayAccess::offsetGet() must be able to return by reference, 
otherwise an E_NOTICE message is raised.".

When &offsetGet() is implemented in a trait, this got broken in 5.4.11 with this 
commit:
https://github.com/php/php-src/commit/3f8c729e693c432b438cd33679182260d8732e30

The patch attached just comments out the check which causes the error. There 
should be a better way to deal with this problem.

Test script:
---------------
<?php
// This code is mostly the same as in the
// http://www.php.net/manual/en/class.arrayaccess.php example,
// but changed to use traits.

trait aa {
    private $container = array();
    public function offsetSet($offset, $value) {
        if (is_null($offset)) {
            $this->container[] = $value;
        } else {
            $this->container[$offset] = $value;
        }
    }
    public function offsetExists($offset) {
        return isset($this->container[$offset]);
    }
    public function offsetUnset($offset) {
        unset($this->container[$offset]);
    }
    public function &offsetGet($offset) {
	$result = null;
        if (isset($this->container[$offset])) {
            $result = &$this->container[$offset];
        }
        return $result;
    }
}

class obj implements ArrayAccess {
    use aa;
}

$o = new obj;
$o['x'] = 1;
++$o['x'];
echo $o['x'], "\n";

Expected result:
----------------
$ ./php-5.4.10/sapi/cli/php OffsetGet.php 

2


Actual result:
--------------
$ ./php5.4-201303122030/sapi/cli/php OffsetGet.php 

Fatal error: Declaration of & aa::offsetGet($offset) must be compatible with 
ArrayAccess::offsetGet($offset) in /home/build/tmp/OffsetGet.php on line 28

Patches

trait_arrayaccess_get_ref.patch (last revision 2013-03-12 22:39 UTC by me at fixxxer dot me)

Pull Requests

History

AllCommentsChangesGit/SVN commitsRelated reports
 [2013-03-14 13:44 UTC] laruence@php.net
-Assigned To: +Assigned To: dmitry
 [2013-03-14 13:44 UTC] laruence@php.net
dmitry, please look at this one.
 [2013-03-19 09:15 UTC] dmitry@php.net
-Status: Assigned +Status: Closed
 [2013-03-19 09:15 UTC] dmitry@php.net
Automatic comment on behalf of dmitry@zend.com
Revision: http://git.php.net/?p=php-src.git;a=commit;h=e62bb0325763d9847847dd198e05c9b3147caf05
Log: Fixed bug #64417 (ArrayAccess::&amp;offsetGet() in a trait causes fatal error)
 [2013-03-19 09:27 UTC] dmitry@php.net
The fix for this bug has been committed.

Snapshots of the sources are packaged every three hours; this change
will be in the next snapshot. You can grab the snapshot at
http://snaps.php.net/.

 For Windows:

http://windows.php.net/snapshots/
 
Thank you for the report, and for helping us make PHP better.


 [2014-10-07 23:19 UTC] stas@php.net
Automatic comment on behalf of dmitry@zend.com
Revision: http://git.php.net/?p=php-src-security.git;a=commit;h=e62bb0325763d9847847dd198e05c9b3147caf05
Log: Fixed bug #64417 (ArrayAccess::&amp;offsetGet() in a trait causes fatal error)
 [2014-10-07 23:31 UTC] stas@php.net
Automatic comment on behalf of dmitry@zend.com
Revision: http://git.php.net/?p=php-src-security.git;a=commit;h=e62bb0325763d9847847dd198e05c9b3147caf05
Log: Fixed bug #64417 (ArrayAccess::&amp;offsetGet() in a trait causes fatal error)
 
PHP Copyright © 2001-2024 The PHP Group
All rights reserved.
Last updated: Tue Dec 03 16:01:33 2024 UTC