php.net |  support |  documentation |  report a bug |  advanced search |  search howto |  statistics |  random bug |  login

go to bug id or search bugs for

Bug #61480 test bug - ext/gd/tests/bug48555.phpt
Submitted: 2012-03-22 21:07 UTC Modified: 2012-04-04 17:19 UTC
From: mattficken@php.net Assigned: ab (profile)
Status: Closed Package: Testing related
PHP Version: 5.3.10 OS:
Private report: No CVE-ID: None
View Developer Edit
Welcome back! If you're the original bug submitter, here's where you can edit the bug or add additional notes.
If you forgot your password, you can retrieve your password here.
Password:
Status:
Package:
Bug Type:
Summary:
From: mattficken@php.net
New email:
PHP Version: OS:

 

 [2012-03-22 21:07 UTC] mattficken@php.net 
Description:
------------
Expected result:
----------------
tests pass

Actual result:
--------------
tests fail
001+ Top without line-break: -15
002+ Top with line-break: -15
001- Top without line-break: -14
002- Top with line-break: -14

Failure occurs with FreeType 2.4.3 which is what PHP uses.

Test patch will skip test if FreeType version is less than 2.4.3.

Patches

bug48555 (last revision 2012-04-03 22:20 UTC by mattficken@php.net)

Pull Requests

History

AllCommentsChangesGit/SVN commitsRelated reports
 [2012-03-22 21:07 UTC] mattficken@php.net 
The following patch has been added/updated:

Patch Name: bug48555
Revision:   1332450447
URL:        https://bugs.php.net/patch-display.php?bug=61480&patch=bug48555&revision=1332450447
 [2012-03-27 12:42 UTC] ab@php.net 
Things are more complicated on linux, that's what the tests give:

FreeType Version => 2.3.11

Current:
001+ Top without line-break: -15
002+ Top with line-break: -15
001- Top without line-break: -14
002- Top with line-break: -14

With patch:
skip


FreeType Version => 2.4.9

Current
pass

With patch:
001+ Top without line-break: -14
002+ Top with line-break: -14
001- Top without line-break: -15
002- Top with line-break: -15
 [2012-04-02 22:58 UTC] mattficken@php.net 
This patch passes on PHP5.3.11rc1 on Windows 7 sp1x64.

It does not break for me on Linux x64 (Gentoo and Fedora 16) with PHP5.3.11rc1.
 [2012-04-03 14:34 UTC] ab@php.net 
As i wrote in the previous comment, even with freetype 2.4.9 it still fails on my debian x86. So with the supplied patch i get

001+ Top without line-break: -14
002+ Top with line-break: -14
001- Top without line-break: -15
002- Top with line-break: -15

which is the old output.

It seems to be additionally a x86/x64 issue in the freetype. May be it would make sense to rewrite the test to calculate "with line break" == "without line break" in the script part, as that's actually the thing supposed to be tested. What do you think?
 [2012-04-03 22:20 UTC] mattficken@php.net 
The following patch has been added/updated:

Patch Name: bug48555
Revision:   1333491620
URL:        https://bugs.php.net/patch-display.php?bug=61480&patch=bug48555&revision=1333491620
 [2012-04-03 22:20 UTC] mattficken@php.net 
Good idea.

I've implemented that in the most recent patch. 

It passes for me with PHP5.3.11rc1 on Gentoo, Fedora-16 and Windows (x86 and x64).
 [2012-04-04 17:16 UTC] ab@php.net 
Automatic comment on behalf of mattficken
Revision: http://git.php.net/?p=php-src.git;a=commit;h=381edb425e16bd5d472c84d757465aa42cb39d0f
Log: Fix bug #61480 test bug - ext/gd/tests/bug48555.phpt
 [2012-04-04 17:19 UTC] ab@php.net
-Status: Open +Status: Closed -Assigned To: +Assigned To: ab
 [2012-04-04 17:19 UTC] ab@php.net 
This bug has been fixed in SVN.

Snapshots of the sources are packaged every three hours; this change
will be in the next snapshot. You can grab the snapshot at
http://snaps.php.net/.

 For Windows:

http://windows.php.net/snapshots/
 
Thank you for the report, and for helping us make PHP better.

Commit is here http://git.php.net/?p=php-src.git;a=commit;h=381edb425e16bd5d472c84d757465aa42cb39d0f
 [2014-10-07 23:27 UTC] stas@php.net 
Automatic comment on behalf of mattficken
Revision: http://git.php.net/?p=php-src-security.git;a=commit;h=381edb425e16bd5d472c84d757465aa42cb39d0f
Log: Fix bug #61480 test bug - ext/gd/tests/bug48555.phpt
 [2014-10-07 23:38 UTC] stas@php.net 
Automatic comment on behalf of mattficken
Revision: http://git.php.net/?p=php-src-security.git;a=commit;h=381edb425e16bd5d472c84d757465aa42cb39d0f
Log: Fix bug #61480 test bug - ext/gd/tests/bug48555.phpt
 
PHP Copyright © 2001-2024 The PHP Group
All rights reserved. 		Last updated: Fri Dec 27 17:01:30 2024 UTC