php.net |  support |  documentation |  report a bug |  advanced search |  search howto |  statistics |  random bug |  login
Bug #60326 ob_gzhander() removed
Submitted: 2011-11-18 07:17 UTC Modified: 2011-12-27 08:13 UTC
Votes:1
Avg. Score:1.0 ± 0.0
Reproduced:0 of 0 (0.0%)
From: stas@php.net Assigned: mike (profile)
Status: Closed Package: Output Control
PHP Version: 5.4.0RC1 OS: *
Private report: No CVE-ID: None
Welcome back! If you're the original bug submitter, here's where you can edit the bug or add additional notes.
If you forgot your password, you can retrieve your password here.
Password:
Status:
Package:
Bug Type:
Summary:
From: stas@php.net
New email:
PHP Version: OS:

 

 [2011-11-18 07:17 UTC] stas@php.net
Description:
------------
ob_gzhandler() function was removed by new output buffering code, but some scripts 
still use it. It would be nice to restore it back if possible. 


Patches

ob_gzhandler.diff.txt (last revision 2011-11-19 10:09 UTC by nicolas dot grekas+php at gmail dot com)

Pull Requests

History

AllCommentsChangesGit/SVN commitsRelated reports
 [2011-11-18 07:18 UTC] stas@php.net
-Assigned To: +Assigned To: mike
 [2011-11-19 10:10 UTC] nicolas dot grekas+php at gmail dot com
The attached patch is by mike.
 [2011-11-20 16:29 UTC] nicolas dot grekas+php at gmail dot com
Same for ob_tidyhandler and ob_iconv_handler.
Found doing a grep php_output_handler_alias_register on source.

If that is considered correct behavior, which I'm personally fine with (but theoretically breaks backward compat), then there is one inconsistency with current implementation : ob aliases have higher precedence than userland function. That is edge case of course.

Consider:

<?php

function ob_iconv_handler($b)
{
  return $b . 'def';
}

ob_start('ob_iconv_handler'); // as I tested: this register the internal alias, not the above function

?>
 [2011-12-26 22:52 UTC] pajoye@php.net
Automatic comment from SVN on behalf of pajoye
Revision: http://svn.php.net/viewvc/?view=revision&amp;revision=321417
Log: - Fix bug #60326, fix crash introduced by initial fix
 [2011-12-27 02:38 UTC] pajoye@php.net
Automatic comment from SVN on behalf of pajoye
Revision: http://svn.php.net/viewvc/?view=revision&amp;revision=321420
Log: - fix bug 60326, fix crash introduce by the fix
 [2011-12-27 08:13 UTC] stas@php.net
This bug has been fixed in SVN.

Snapshots of the sources are packaged every three hours; this change
will be in the next snapshot. You can grab the snapshot at
http://snaps.php.net/.

 For Windows:

http://windows.php.net/snapshots/
 
Thank you for the report, and for helping us make PHP better.


 [2011-12-27 08:13 UTC] stas@php.net
-Status: Assigned +Status: Closed
 [2012-04-18 09:46 UTC] laruence@php.net
Automatic comment on behalf of pajoye
Revision: http://git.php.net/?p=php-src.git;a=commit;h=dfa30f03b6db930e4f68830d3bd4d89c7135cfe7
Log: - Fix bug #60326, fix TS build (introduced by r321406)
 [2012-04-18 09:46 UTC] laruence@php.net
Automatic comment on behalf of stas
Revision: http://git.php.net/?p=php-src.git;a=commit;h=bb6855124da5862a7525bd15620c8a6d46d91560
Log: fix bug #60326 - restore ob_gzhandler
 [2012-07-24 23:37 UTC] rasmus@php.net
Automatic comment on behalf of pajoye
Revision: http://git.php.net/?p=php-src.git;a=commit;h=dfa30f03b6db930e4f68830d3bd4d89c7135cfe7
Log: - Fix bug #60326, fix TS build (introduced by r321406)
 [2012-07-24 23:37 UTC] rasmus@php.net
Automatic comment on behalf of stas
Revision: http://git.php.net/?p=php-src.git;a=commit;h=bb6855124da5862a7525bd15620c8a6d46d91560
Log: fix bug #60326 - restore ob_gzhandler
 [2013-11-17 09:34 UTC] laruence@php.net
Automatic comment on behalf of pajoye
Revision: http://git.php.net/?p=php-src.git;a=commit;h=dfa30f03b6db930e4f68830d3bd4d89c7135cfe7
Log: - Fix bug #60326, fix TS build (introduced by r321406)
 [2013-11-17 09:34 UTC] laruence@php.net
Automatic comment on behalf of stas
Revision: http://git.php.net/?p=php-src.git;a=commit;h=bb6855124da5862a7525bd15620c8a6d46d91560
Log: fix bug #60326 - restore ob_gzhandler
 
PHP Copyright © 2001-2024 The PHP Group
All rights reserved.
Last updated: Thu Dec 26 11:01:30 2024 UTC