php.net |  support |  documentation |  report a bug |  advanced search |  search howto |  statistics |  random bug |  login
Bug #59634 fix build #1
Submitted: 2011-02-21 12:17 UTC Modified: 2011-02-22 11:02 UTC
From: pajoye@php.net Assigned: bd808 (profile)
Status: Closed Package: yaml (PECL)
PHP Version: 5_3 SVN-2011-02-21 (dev) OS: windows
Private report: No CVE-ID: None
Welcome back! If you're the original bug submitter, here's where you can edit the bug or add additional notes.
If you forgot your password, you can retrieve your password here.
Password:
Status:
Package:
Bug Type:
Summary:
From: pajoye@php.net
New email:
PHP Version: OS:

 

 [2011-02-21 12:17 UTC] pajoye@php.net
Description:
------------
hi,

Here is a 1st patch to fix yaml build on windows:

http://www.php.net/~pierre/yaml_fix_win_build_part_1.txt

There are other linker issues but will fix them later.

Cheers,


Patches

Pull Requests

History

AllCommentsChangesGit/SVN commitsRelated reports
 [2011-02-22 00:38 UTC] bd808@php.net
I applied your changes to config.w32 and parse.c. The change you proposed for yaml.c breaks runtime usage and the change to emit.c is redundant since yaml.h is included in the php_yaml.h header.
 [2011-02-22 05:17 UTC] pierre dot php at gmail dot com
This double declaration in yaml.c is wrong. Do you test the 
build under thread safe mode or normal (nts) mode?
 [2011-02-22 06:04 UTC] pierre dot php at gmail dot com
Applied the required changes directly to svn, hope you don't 
mind. The two last problems were:

- declaration of the yaml globals using PHP_API in yaml.c but 
not in php_yaml.h
- missing flag for static libyaml usage
 [2011-02-22 11:02 UTC] bd808@php.net
No worries about the direct commit. The whole point of hosting the project with php.net is to get assistance from others in keeping the code clean and functional.

I have been testing under nts against Ubuntu 10.04's php distribution. Does pecl have a build farm somewhere that would let me test against a wider variety of php distributions and configurations?
 
PHP Copyright © 2001-2025 The PHP Group
All rights reserved.
Last updated: Sun Jan 05 02:01:28 2025 UTC