php.net |  support |  documentation |  report a bug |  advanced search |  search howto |  statistics |  random bug |  login

go to bug id or search bugs for

Bug #58487 -Werror=format-security
Submitted: 2009-01-04 06:54 UTC Modified: 2015-04-07 19:51 UTC
From: oden dot eriksson at envitory dot se Assigned:
Status: Suspended Package: colorer (PECL)
PHP Version: 5.2.5 OS: Linux
Private report: No CVE-ID: None
View Developer Edit
Welcome back! If you're the original bug submitter, here's where you can edit the bug or add additional notes.
If you forgot your password, you can retrieve your password here.
Password:
Status:
Package:
Bug Type:
Summary:
From: oden dot eriksson at envitory dot se
New email:
PHP Version: OS:

 

 [2009-01-04 06:54 UTC] oden dot eriksson at envitory dot se 
Description:
------------
The build fails with -Werror=format-security


Reproduce code:
---------------
/home/oden/RPM/BUILD/colorer-0.7/colorer.cpp:628: error: format not a string literal and no format arguments


Expected result:
----------------
It should build, and also preferably without all those compiler warnings.



Actual result:
--------------
Proposed fix:

--- colorer.cpp 2005-11-21 08:26:13.000000000 +0100
+++ colorer.cpp.oden    2009-01-04 12:46:43.000000000 +0100
@@ -625,7 +625,7 @@ static int colorer_do_highlight(INTERNAL
                        catch(Exception & e) {
                                php_error(E_WARNING, "can't open file '%s' for writing:\n",
                                                  outFile->getChars());
-                               php_error(E_WARNING, e.getMessage()->getChars());
+                               php_error(E_WARNING, "%s", e.getMessage()->getChars());
                                return FAILURE;
                        }
                }

Patches

Pull Requests

History

AllCommentsChangesGit/SVN commitsRelated reports
 [2015-04-07 19:51 UTC] cmb@php.net
-Status: Open +Status: Suspended
 [2015-04-07 19:51 UTC] cmb@php.net 
Sorry, but apparently this package is not maintained anymore.
Marking this bug as "Suspended" for now.
 
PHP Copyright © 2001-2024 The PHP Group
All rights reserved. 		Last updated: Sat Dec 21 16:01:28 2024 UTC