php.net |  support |  documentation |  report a bug |  advanced search |  search howto |  statistics |  random bug |  login

go to bug id or search bugs for

Bug #56854 type correction for strict compiler
Submitted: 2006-02-22 12:28 UTC Modified: 2006-03-20 00:59 UTC
From: info at gknw dot de Assigned:
Status: Closed Package: svn (PECL)
PHP Version: Irrelevant OS: NetWare, Win32
Private report: No CVE-ID: None
View Developer Edit
Welcome back! If you're the original bug submitter, here's where you can edit the bug or add additional notes.
If you forgot your password, you can retrieve your password here.
Password:
Status:
Package:
Bug Type:
Summary:
From: info at gknw dot de
New email:
PHP Version: OS:

 

 [2006-02-22 12:28 UTC] info at gknw dot de 
Description:
------------
Hi,
the compiler I have to use for producing a NetWare php_svn binary is very strict, and breaks with const char* type mismatch...




Reproduce code:
---------------
--- svn.c.orig	Sun Feb 12 23:52:36 2006
+++ svn.c	Sun Feb 12 23:59:30 2006
@@ -1942,7 +1942,7 @@
 {
 	zval *ztxn;
 	struct php_svn_repos_fs_txn *txn;
-	char *conflicts;
+	const char *conflicts;
 	svn_revnum_t new_rev;
 	svn_error_t *err;

Patches

Pull Requests

History

AllCommentsChangesGit/SVN commitsRelated reports
 [2006-03-19 14:37 UTC] info at gknw dot de 
Hi,
now I've also succeeded with the Win32 binary which needed another include svn_utf.h which in turn caused me another type mismatch for NetWare...., argh! So the new complete patch which works on both NetWare and Win32 looks now:

--- svn.c.orig	Sun Feb 12 23:52:36 2006
+++ svn.c	Sun Mar 19 19:51:02 2006
@@ -36,6 +36,7 @@
 #include "svn_path.h"
 #include "svn_fs.h"
 #include "svn_repos.h"
+#include "svn_utf.h"
 
 /* If you declare any globals in php_svn.h uncomment this: */
 ZEND_DECLARE_MODULE_GLOBALS(svn)
@@ -778,7 +779,7 @@
  
 PHP_FUNCTION(svn_log)
 {
-	char *repos_url = NULL, *utf8_repos_url = NULL; 
+	const char *repos_url = NULL, *utf8_repos_url = NULL; 
 	int repos_url_len;
 	int revision = -2;
 	svn_error_t *err;
@@ -1942,7 +1943,7 @@
 {
 	zval *ztxn;
 	struct php_svn_repos_fs_txn *txn;
-	char *conflicts;
+	const char *conflicts;
 	svn_revnum_t new_rev;
 	svn_error_t *err;
 [2006-03-19 19:41 UTC] info at gknw dot de 
For those who like to play around on Win32 with this great extension, here's a binary for PHP 5.1.2 + Subversion 1.3.0:
http://www.gknw.at/test/svn/win32/
for NetWare use my complete PHP distributions which contain now the extension.
 [2006-03-20 00:59 UTC] alan at akbkhome dot com 
This bug has been fixed in CVS.

In case this was a documentation problem, the fix will show up at the
end of next Sunday (CET) on pecl.php.net.

In case this was a pecl.php.net website problem, the change will show
up on the website in short time.
 
Thank you for the report, and for helping us make PECL better.
 
PHP Copyright © 2001-2025 The PHP Group
All rights reserved. 		Last updated: Wed Feb 05 08:01:30 2025 UTC