php.net |  support |  documentation |  report a bug |  advanced search |  search howto |  statistics |  random bug |  login

go to bug id or search bugs for

Bug #56105 Unapproved packages show in package browser
Submitted: 2004-06-19 06:38 UTC Modified: 2004-06-20 10:43 UTC
From: demenev at on-line dot jar dot ru Assigned: danielc (profile)
Status: Closed Package: PECL website (PECL)
PHP Version: Irrelevant OS: N/A
Private report: No CVE-ID: None
View Developer Edit
Welcome back! If you're the original bug submitter, here's where you can edit the bug or add additional notes.
If you forgot your password, you can retrieve your password here.
Password:
Status:
Package:
Bug Type:
Summary:
From: demenev at on-line dot jar dot ru
New email:
PHP Version: OS:

 

 [2004-06-19 06:38 UTC] demenev at on-line dot jar dot ru 
Description:
------------
Package browser ( http://pear.php.net/packages.php ) shows packages which are not yet approved. Provided patch fixes it

Reproduce code:
---------------
Index: packages.php
===================================================================
RCS file: /repository/pearweb/public_html/packages.php,v
retrieving revision 1.44
diff -u -r1.44 packages.php
--- packages.php    9 Jun 2004 06:14:02 -0000   1.44
+++ packages.php    19 Jun 2004 10:44:43 -0000
@@ -103,7 +103,7 @@
 
 // 1) Show categories of this level
 $sth = $dbh->query("SELECT c.*, COUNT(p.id) AS npackages FROM categories c LEFT JOIN packages p ON p.category = c.id ".
-                    "WHERE p.package_type = 'pear' AND c.parent $category_where ".
+                    "WHERE p.package_type = 'pear' AND p.approved = 1 AND c.parent $category_where ".
                     "GROUP BY c.id ORDER BY name");
 
 $table   = new HTML_Table('border="0" cellpadding="6" cellspacing="2" width="100%"');
@@ -122,6 +122,7 @@
                           "  FROM packages p, categories c".
                           " WHERE c.parent $category_where ".
                           "   AND p.package_type = 'pear' ".
+                          "   AND p.approved = 1 ".
                           "   AND p.category = c.id ORDER BY p.name",
                           false, null, DB_FETCHMODE_ASSOC, true);

Patches

Pull Requests

History

AllCommentsChangesGit/SVN commitsRelated reports
 [2004-06-20 10:43 UTC] danielc at analysisandsolutions dot com 
Thanks so much.
 
PHP Copyright © 2001-2025 The PHP Group
All rights reserved. 		Last updated: Wed Feb 05 09:01:30 2025 UTC