php.net |  support |  documentation |  report a bug |  advanced search |  search howto |  statistics |  random bug |  login

go to bug id or search bugs for

Bug #55671 clean up the php 6 references in run-tests.php
Submitted: 2011-09-12 11:30 UTC Modified: 2018-08-05 23:02 UTC
From: tyrael@php.net Assigned: carusogabriel (profile)
Status: Closed Package: Testing related
PHP Version: Irrelevant OS:
Private report: No CVE-ID: None
View Developer Edit
Welcome back! If you're the original bug submitter, here's where you can edit the bug or add additional notes.
If you forgot your password, you can retrieve your password here.
Password:
Status:
Package:
Bug Type:
Summary:
From: tyrael@php.net
New email:
PHP Version: OS:

 

 [2011-09-12 11:30 UTC] tyrael@php.net 
Description:
------------
there are mentions and special cases for working with php6, which isn't valid 
anymore.
we should remove those(unicode string/binary string types), and there are some, 
which should be enabled for >= 504000:
magic_quotes, safe_mode check, as those are removed with 5.4

Patches

Pull Requests

History

AllCommentsChangesGit/SVN commitsRelated reports
 [2011-09-13 06:38 UTC] sixd@php.net 
A number of phpt's still have the PHP 6 syntax. These would need to be updated 
before the string type change is made to run-tests.php
 [2011-09-26 23:38 UTC] tyrael@php.net
-Package: *General Issues +Package: Testing related
 [2012-09-08 14:57 UTC] reeze dot xia at gmail dot com 
Do we still have the problem?

I saw only one place have php6 specific test in run-tests.php

if (PHP_MAJOR_VERSION < 6) {
    ini_set('magic_quotes_runtime',0); // this would break tests by modifying 
EXPECT sections
    if (ini_get('safe_mode')) {
        echo <<< SAFE_MODE_WARNING
 [2012-09-09 09:05 UTC] laruence@php.net 
"MAJOR_VERSION < 6" has nothing to do with PHP 6, what do you expected? 
MAJOR_VERSION <= 5?
 [2012-09-09 09:31 UTC] reeze dot xia at gmail dot com 
PHP6 didn't exist so that test was useless, as tyrael said,
safe_mode have been removed with 5.4.
 [2012-09-09 09:42 UTC] laruence@php.net 
I really don't understand your point. did you read the codes carefully?

it's not a php 6 specifc test, it's about to generate a warning about safe_mode.

it has nothing to do with php 6.  5.2 5.3 still have safe_mode. then MAJOR_VERSOIN 
of them will meet that condition..
 [2012-09-09 09:58 UTC] reeze dot xia at gmail dot com 
Yes, 
I'm not saying that is a php6's feature.
I mean the outmost "if (PHP_MAJOR_VERSION < 6)“ checking is not accurate
since PHP6 is going nowhere. That checking is useful in < 5.4 but not 6 :)

This issue was related to PHP6 cleanup,
so I mention that here.
 [2018-08-05 23:02 UTC] carusogabriel@php.net
-Status: Open +Status: Closed -Assigned To: +Assigned To: carusogabriel
 [2018-08-05 23:02 UTC] carusogabriel@php.net 
Closing as it was solved via http://git.php.net/?p=php-src.git;a=commit;h=5af586be
 
PHP Copyright © 2001-2024 The PHP Group
All rights reserved. 		Last updated: Fri Dec 27 16:01:29 2024 UTC