php.net |  support |  documentation |  report a bug |  advanced search |  search howto |  statistics |  random bug |  login

go to bug id or search bugs for

Request #55094 Suppress favicon.ico requests or return a PHP favicon
Submitted: 2011-06-30 21:54 UTC Modified: 2011-07-20 06:27 UTC
Votes:1
Avg. Score:3.0 ± 0.0
Reproduced:1 of 1 (100.0%)
Same Version:1 (100.0%)
Same OS:0 (0.0%)
From: sixd@php.net Assigned: moriyoshi (profile)
Status: Wont fix Package: Built-in web server
PHP Version: 5.4SVN-2011-07-01 (SVN) OS: All
Private report: No CVE-ID: None
View Developer Edit
Welcome back! If you're the original bug submitter, here's where you can edit the bug or add additional notes.
If you forgot your password, you can retrieve your password here.
Password:
Status:
Package:
Bug Type:
Summary:
From: sixd@php.net
New email:
PHP Version: OS:

 

 [2011-06-30 21:54 UTC] sixd@php.net 
Description:
------------
Each in-built web server request generates three log lines for favicon.ico unless one is present.  For quick development use, this reduces usability.  

The options are:

(i) return a favicon if one exists else do (ii) or (iii)
(ii) return a hardcoded PHP favicon
(iii) don't log favicon.ico failures
(iv) ignore favicon.ico requests altogether

A sample patch for (iv) is attached.

Patches

builtin-web-server-default-favicon.patch.diff (last revision 2011-07-20 08:36 UTC by moriyoshi@php.net)
favicon.patch.txt (last revision 2011-07-01 01:56 UTC by a at example dot com)

Pull Requests

History

AllCommentsChangesGit/SVN commitsRelated reports
 [2011-07-03 09:25 UTC] felipe@php.net
-Status: Open +Status: Assigned -Assigned To: +Assigned To: moriyoshi
 [2011-07-08 18:30 UTC] kalle@php.net 
I think we might aswell just serve a favicon for the giggles of it, and can easily be implemented by using the same tactic as we do for other php logos in main/
 [2011-07-20 04:35 UTC] moriyoshi@php.net
-Status: Assigned +Status: Wont fix -Type: Bug +Type: Feature/Change Request
 [2011-07-20 04:35 UTC] moriyoshi@php.net 
I actually implemented this feature, but I don't think this makes sense since 
logs are generated anyway if the corresponding file is present.  Plus, it's not a 
good idea to make a web server falsefully respond to a request.
 [2011-07-20 04:36 UTC] moriyoshi@php.net 
The following patch has been added/updated:

Patch Name: builtin-web-server-default-favicon.patch.diff
Revision:   1311150991
URL:        https://bugs.php.net/patch-display.php?bug=55094&patch=builtin-web-server-default-favicon.patch.diff&revision=1311150991
 [2011-07-20 06:27 UTC] fa@php.net 
Agreed on the first patch, for me it even made requests for /favicon.ico hang 
(probably until timeout)

But with the included-icon patch, what's the downside with it? (Maybe it would 
make sense to send_static a real favicon.ico if it's in the docroot)
 
PHP Copyright © 2001-2024 The PHP Group
All rights reserved. 		Last updated: Sat Dec 21 13:01:31 2024 UTC