php.net |  support |  documentation |  report a bug |  advanced search |  search howto |  statistics |  random bug |  login

go to bug id or search bugs for

Bug #53530 php_crypt tests gcc version incorrectly due to typo
Submitted: 2010-12-12 22:39 UTC Modified: 2011-02-01 16:41 UTC
From: vapier at gmail dot com Assigned: cataphract (profile)
Status: Closed Package: Compile Failure
PHP Version: 5.3.4 OS: Linux
Private report: No CVE-ID: None
View Developer Edit
Welcome back! If you're the original bug submitter, here's where you can edit the bug or add additional notes.
If you forgot your password, you can retrieve your password here.
Password:
Status:
Package:
Bug Type:
Summary:
From: vapier at gmail dot com
New email:
PHP Version: OS:

 

 [2010-12-12 22:39 UTC] vapier at gmail dot com 
Description:
------------
the ext/standard/php_crypt_r.c code supports atomic ops, but it tests for the gcc version incorrectly due to a typo in the define name:
...
#elif (defined(__GNUC__) && (__GNUC__ >= 4 && __GNUC_MINOR >= 2))
        __sync_fetch_and_add(&initialized, 1);
...

gcc defines "__GNUC_MINOR__", not "__GNUC_MINOR".

Patches

Pull Requests

History

AllCommentsChangesGit/SVN commitsRelated reports
 [2010-12-12 23:27 UTC] cataphract@php.net 
Automatic comment from SVN on behalf of cataphract
Revision: http://svn.php.net/viewvc/?view=revision&revision=306305
Log: - Fixed bug #53530 (php_crypt tests gcc version incorrectly due to
  typo) (vapier at gmail dot com)
 [2010-12-12 23:28 UTC] cataphract@php.net
-Status: Open +Status: Closed -Assigned To: +Assigned To: cataphract
 [2010-12-12 23:28 UTC] cataphract@php.net 
Fixed. I wonder why the atomic operation is used though, because the section is protected with a lock.
 [2011-02-01 16:39 UTC] aaron dot styx at baesystems dot com 
This was supposedly fixed, but I just downloaded the most recent version of php (5.3.5), and the typo still exists.
 [2011-02-01 16:41 UTC] cataphract@php.net 
PHP 5.3.5 was an urgent release fixing only the float bug. The rest of the fixes will be only in PHP 5.3.6.
 
PHP Copyright © 2001-2025 The PHP Group
All rights reserved. 		Last updated: Fri Apr 18 19:01:26 2025 UTC