I ended up implemented a better strategy than separate+clear flag, as that broke a few tests that expected the fci.params's zvals not to have the reference flag changed.

This patch breaks only two tests that explicitly tested for the previous behavior.

I've left the exception that was introduced for bug #50394, though I think it should be removed for trunk.

It makes no sense to disallow this:

<?php
class A {
function __call($name, $args) {
var_dump($args);
}
}

$a = new A;
$b = 6;
$a->foobar(&$a);

yet allow this:

<?php
class A {
function __call($name, $args) {
var_dump($args);
}
}

$a = new A;
$b = 6;
call_user_func_array(array($a, 'foobar'), array(&$b));


The problem described in bug #50394 could easily be worked around by, instead of passing by reference to __call, give the argument in an array instead:

<?php
function foo( &$x ) { $x++; }

class Proxy {
	function __call( $name, $args ) {
		call_user_func_array( 'foo', $args[0] );
	}
}

$arg = 1;
$args = array( &$arg );
$proxy = new Proxy;
call_user_func_array( array( $proxy, 'bar' ), array($args) );
var_dump($arg);

hi Dmitry,

Can you look at this pls?

Fixing this would also fix bug #51986.

This bug has been fixed in SVN.

Snapshots of the sources are packaged every three hours; this change
will be in the next snapshot. You can grab the snapshot at
http://snaps.php.net/.
 
Thank you for the report, and for helping us make PHP better.