php.net |  support |  documentation |  report a bug |  advanced search |  search howto |  statistics |  random bug |  login
Bug #47848 importNode doesn't preserve attribute namespaces
Submitted: 2009-03-31 11:29 UTC Modified: 2009-12-03 20:21 UTC
Votes:2
Avg. Score:3.0 ± 0.0
Reproduced:2 of 2 (100.0%)
Same Version:1 (50.0%)
Same OS:2 (100.0%)
From: robin2008 at altruists dot org Assigned:
Status: Closed Package: DOM XML related
PHP Version: 5.2.9 OS: Ubuntu
Private report: No CVE-ID: None
Welcome back! If you're the original bug submitter, here's where you can edit the bug or add additional notes.
If you forgot your password, you can retrieve your password here.
Password:
Status:
Package:
Bug Type:
Summary:
From: robin2008 at altruists dot org
New email:
PHP Version: OS:

 

 [2009-03-31 11:29 UTC] robin2008 at altruists dot org
Description:
------------
I was expecting importNode to preserve attribute namespaces.
It doesn't

Reproduce code:
---------------
<?php
// PHP 5.2.* namespace bug - importNode doesn't preserve attribute namespaces

$aDOM= new DOMDocument();
$aDOM->appendChild($aDOM->createElementNS('http://friend2friend.net/','f2f:a'));
echo 'DOM to add into is '.$aDOM->saveXML().chr(13);

$fromdom= DOMDocument::loadXML('<data xmlns:ai=" http://altruists.org " ai:attr="namespaced" />');
echo 'Dom to import from is'.$fromdom->saveXML().chr(13);

$attr= $fromdom->firstChild->attributes->item(0);

$aDOM->documentElement->appendChild($aDOM->importNode($attr));
echo 'Result is '.$aDOM->saveXML();

// The following script gets round this bug

function importAttrNS($targetNode, $attr)
	{ // Last modified 2009-01-26	Imports an attribute without losing the NS, if present
	if ($attr->prefix=='') $targetNode->appendChild($targetNode->ownerDocument->importNode($attr));
	else $targetNode->setAttributeNS($attr->lookupNamespaceURI($attr->prefix), $attr->prefix.':'.$attr->name, $attr->value);
	}
?>

Expected result:
----------------
The imported attribute should keep its namespace.

Actual result:
--------------
The imported attribute becomes unnamespaced.

Patches

Pull Requests

History

AllCommentsChangesGit/SVN commitsRelated reports
 [2009-12-03 20:19 UTC] svn@php.net
Automatic comment from SVN on behalf of rrichards
Revision: http://svn.php.net/viewvc/?view=revision&revision=291669
Log: fix bug #47848 (importNode doesn't preserve attribute namespaces)
add tests
 [2009-12-03 20:21 UTC] rrichards@php.net
This bug has been fixed in SVN.

Snapshots of the sources are packaged every three hours; this change
will be in the next snapshot. You can grab the snapshot at
http://snaps.php.net/.
 
Thank you for the report, and for helping us make PHP better.


 
PHP Copyright © 2001-2024 The PHP Group
All rights reserved.
Last updated: Thu Nov 21 15:01:30 2024 UTC