|
php.net | support | documentation | report a bug | advanced search | search howto | statistics | random bug | login |
PatchesPull Requests
Pull requests:
HistoryAllCommentsChangesGit/SVN commits
[2009-03-20 11:23 UTC] pajoye@php.net
[2010-12-20 14:26 UTC] jani@php.net
-Package: Feature/Change Request
+Package: OpenSSL related
[2017-10-24 07:33 UTC] kalle@php.net
-Status: Assigned
+Status: Open
-Assigned To: pajoye
+Assigned To:
[2024-01-19 00:39 UTC] info at gomarketes dot exchange
[2025-08-11 17:36 UTC] bukka@php.net
[2025-08-11 17:49 UTC] bukka@php.net
-Status: Open
+Status: Assigned
-Assigned To:
+Assigned To: bukka
[2025-08-11 17:49 UTC] bukka@php.net
[2025-08-11 18:47 UTC] git@php.net
[2025-08-11 18:47 UTC] git@php.net
-Status: Assigned
+Status: Closed
|
|||||||||||||||||||||||||||
Copyright © 2001-2025 The PHP GroupAll rights reserved. |
Last updated: Mon Oct 27 14:00:01 2025 UTC |
Description: ------------ openssl_pkcs7_sign supports several new flags: e.g. PKCS7_CRLFEOL,PKCS7_NOSMIMECAP... 1. openssl extension should define these constants 2. openssl extension should check the PKCS7_CRLFEOL and use appropriate line delimiter in call to BIO_printf() Reproduce code: --------------- look at ext\openssl\openssl.c Expected result: ---------------- 1) also new constants should be registered here REGISTER_LONG_CONSTANT("PKCS7_NOSMIMECAP", PKCS7_NOSMIMECAP, CONST_CS|CONST_PERSISTENT); REGISTER_LONG_CONSTANT("PKCS7_NOOLDMIMETYPE", PKCS7_NOOLDMIMETYPE, CONST_CS|CONST_PERSISTENT); REGISTER_LONG_CONSTANT("PKCS7_CRLFEOL", PKCS7_CRLFEOL, CONST_CS|CONST_PERSISTENT); REGISTER_LONG_CONSTANT("PKCS7_STREAM", PKCS7_STREAM, CONST_CS|CONST_PERSISTENT); REGISTER_LONG_CONSTANT("PKCS7_NOCRL", PKCS7_NOCRL, CONST_CS|CONST_PERSISTENT); 2) newline symbol should depend on PKCS7_CRLFEOL flag (this style of coding is taken from openssl project itself) if (flags & PKCS7_CRLFEOL) mime_eol = "\r\n"; else mime_eol = "\n"; if (strindex) { BIO_printf(outfile, "%s: %s%s", strindex, Z_STRVAL_PP(hval),mime_eol); } else { BIO_printf(outfile, "%s%s", Z_STRVAL_PP(hval),mime_eol); } Actual result: -------------- look at ext\openssl\openssl.c 1) Line 701: /* flags for S/MIME */ - only old flags are defined here 2) if (strindex) { BIO_printf(outfile, "%s: %s\n", strindex, Z_STRVAL_PP(hval)); } else { BIO_printf(outfile, "%s\n", Z_STRVAL_PP(hval)); }