php.net |  support |  documentation |  report a bug |  advanced search |  search howto |  statistics |  random bug |  login

go to bug id or search bugs for

Bug #44975 ext/date/php_date has comments starting with //
Submitted: 2008-05-12 20:39 UTC Modified: 2008-07-08 18:03 UTC
From: orchard at engr dot wisc dot edu Assigned: derick (profile)
Status: Closed Package: Compile Failure
PHP Version: 5.2.6 OS: Solaris 9
Private report: No CVE-ID: None
View Developer Edit
Welcome back! If you're the original bug submitter, here's where you can edit the bug or add additional notes.
If you forgot your password, you can retrieve your password here.
Password:
Status:
Package:
Bug Type:
Summary:
From: orchard at engr dot wisc dot edu
New email:
PHP Version: OS:

 

 [2008-05-12 20:39 UTC] orchard at engr dot wisc dot edu 
Description:
------------
ext/date/php_date.c has comments starting with // rather than enclosed in /* and */  The Sun WS6 compiler does no accept such comments.

[tiger] 149% diff -c php_date.c.orig php_date.c
*** php_date.c.orig     Wed Apr 16 12:21:46 2008
--- php_date.c  Mon May 12 15:08:17 2008
***************
*** 269,277 ****
        int             initialized;
        int             type;
        union {
!               timelib_tzinfo *tz; // TIMELIB_ZONETYPE_ID;
!               timelib_sll     utc_offset; // TIMELIB_ZONETYPE_OFFSET
!               struct                      // TIMELIB_ZONETYPE_ABBR
                {
                        timelib_sll  utc_offset;
                        char        *abbr;
--- 269,277 ----
        int             initialized;
        int             type;
        union {
!               timelib_tzinfo *tz; /* TIMELIB_ZONETYPE_ID; */
!               timelib_sll     utc_offset; /* TIMELIB_ZONETYPE_OFFSET */
!               struct                      /* TIMELIB_ZONETYPE_ABBR */
                {
                        timelib_sll  utc_offset;
                        char        *abbr;

Patches

Pull Requests

History

AllCommentsChangesGit/SVN commitsRelated reports
 [2008-05-12 20:42 UTC] derick@php.net 
Already noticed it, but hadn't patched it.
 [2008-07-08 18:03 UTC] derick@php.net 
This bug has been fixed in CVS.

Snapshots of the sources are packaged every three hours; this change
will be in the next snapshot. You can grab the snapshot at
http://snaps.php.net/.
 
Thank you for the report, and for helping us make PHP better.
 
PHP Copyright © 2001-2025 The PHP Group
All rights reserved. 		Last updated: Thu Jul 17 14:04:04 2025 UTC