php.net |  support |  documentation |  report a bug |  advanced search |  search howto |  statistics |  random bug |  login

go to bug id or search bugs for

Bug #37500 Patches for GtkContainer::get/set_focus_chain, GtkWindow::g/s_default_icons
Submitted: 2006-05-18 14:32 UTC Modified: 2006-06-09 17:44 UTC
From: cweiske@php.net Assigned:
Status: Closed Package: PHP-GTK related
PHP Version: 5.1.4 OS: any
Private report: No CVE-ID: None
View Developer Edit
Welcome back! If you're the original bug submitter, here's where you can edit the bug or add additional notes.
If you forgot your password, you can retrieve your password here.
Password:
Status:
Package:
Bug Type:
Summary:
From: cweiske@php.net
New email:
PHP Version: OS:

 

 [2006-05-18 14:32 UTC] cweiske@php.net 
Description:
------------
Attached are patches for the following methods:
GtkContainer::get_focus_chain
GtkContainer::set_focus_chain
GtkWindow::get_icon_list
GtkWindow::set_icon_list
GtkWindow::get_default_icon_list
GtkWindow::set_default_icon_list
GtkIconTheme::list_icons

The patch files can be found at
http://xml.cweiske.de/patches/gtk.defs.diff
http://xml.cweiske.de/patches/gtkcontainer.overrides.diff
http://xml.cweiske.de/patches/gtk.overrides.diff

Patches

Pull Requests

History

AllCommentsChangesGit/SVN commitsRelated reports
 [2006-06-03 19:39 UTC] andrei@php.net 
A couple of notes:

1. You should prepend the widgets to the focus chain, instead of appending. Also, use better error messages:

+        if (php_gtk_check_class(*php_widget, gtkwidget_ce)) {
+            GtkWidget *widget = GTK_WIDGET(PHPG_GOBJECT(*php_widget));
+            widgets = g_list_prepend(widgets, widget);
+        } else {
+            php_error(E_WARNING, "%s::%s() requires the focus chain elements to be objects of class GtkWidget", get_active_class_name(NULL TSRMLS_CC), get_active_function_name(TSRMLS_C));
+        }

2. Why do you have this in gtk.defs:

+(define-function gtk_tree_model_filter_new

3. See #1 for set_(default)_icon_list() also.
 [2006-06-09 17:44 UTC] cweiske@php.net 
This bug has been fixed in CVS.

Snapshots of the sources are packaged every three hours; this change
will be in the next snapshot. You can grab the snapshot at
http://snaps.php.net/.
 
Thank you for the report, and for helping us make PHP better.
 
PHP Copyright © 2001-2024 The PHP Group
All rights reserved. 		Last updated: Sat Dec 21 17:01:58 2024 UTC