|
php.net | support | documentation | report a bug | advanced search | search howto | statistics | random bug | login |
PatchesPull RequestsHistoryAllCommentsChangesGit/SVN commits
[2001-07-30 13:03 UTC] sniper@php.net
|
|||||||||||||||||||||||||||
Copyright © 2001-2025 The PHP GroupAll rights reserved. |
Last updated: Tue Oct 28 22:00:01 2025 UTC |
Some users observed that read_exif_data is too slow with 1MB image files, which is a typical size for digital camera output. I looked into the implementation (ext/exif/exif.c) and it looks like the whole compressed image data is always read into memory, even though read_exif_data should be concerned with just the file header. Here's a line from function read_exif_data: <PRE> ret = php_read_jpeg_exif(&ImageInfo, (*p_name)->value.str.val,1); </PRE> The last parameter (ReadAll=1), causes the whole image data loaded into memory inside function scan_JPEG_header: <PRE> if (ReadAll) { int cp, ep, size; /* Determine how much file is left. */ cp = ftell(infile); fseek(infile, 0, SEEK_END); ep = ftell(infile); fseek(infile, cp, SEEK_SET); size = ep-cp; Data = (uchar *)malloc(size); if (Data == NULL) { php_error(E_ERROR,"could not allocate data for entire image"); } got = fread(Data, 1, size, infile); if (got != size) { php_error(E_ERROR,"could not read the rest of the image"); } Sections[*SectionsRead].Data = Data; Sections[*SectionsRead].Size = size; Sections[*SectionsRead].Type = PSEUDO_IMAGE_MARKER; (*SectionsRead)++; /* *HaveAll = 1; */ } return TRUE; </PRE> I believe the line above should be changed to feed 0 as value of parameter ReadAll. Thanks. V