php.net |  support |  documentation |  report a bug |  advanced search |  search howto |  statistics |  random bug |  login
Bug #78077 move_uploaded_file ignores stream_flush return value of reg. streamWrapper
Submitted: 2019-05-28 09:22 UTC Modified: 2021-08-18 11:10 UTC
Votes:3
Avg. Score:3.7 ± 1.9
Reproduced:2 of 3 (66.7%)
Same Version:0 (0.0%)
Same OS:1 (50.0%)
From: daniel dot pernold at gmail dot com Assigned: cmb (profile)
Status: Duplicate Package: Streams related
PHP Version: 7.2.18 OS: Ubuntu 18.04
Private report: No CVE-ID: None
View Developer Edit
Welcome! If you don't have a Git account, you can't do anything here.
If you reported this bug, you can edit this bug over here.
(description)
Block user comment
Status: Assign to:
Package:
Bug Type:
Summary:
From: daniel dot pernold at gmail dot com
New email:
PHP Version: OS:

 

 [2019-05-28 09:22 UTC] daniel dot pernold at gmail dot com
Description:
------------
PHP 7.2.17-0ubuntu0.18.04.1 (cli) (built: Apr 18 2019 14:12:38) ( NTS )

When using `move_uploaded_file` with a stream wrapper url as destination, the return value of the method `stream_flush` is ignored. The function `move_uploaded_file` always returns true, even if `stream_flush` returns false.

Test script:
---------------
class MyStreamWrapper
{
    ...

    public function stream_write($data)
    {
        return 1;
    }

    public function stream_flush()
    {
        return false;
    }

    ...
}

stream_wrapper_register('my-wrapper', \MyStreamWrapper::class, 0);
$res = move_uploaded_file($_FILES['uploaded_file']['tmp_name'], 'my-wrapper://' . basename($_FILES['uploaded_file']['name']));
stream_wrapper_unregister('my-wrapper');
echo $res ? 'true' : 'false';



Expected result:
----------------
false

Actual result:
--------------
true

Patches

Pull Requests

History

AllCommentsChangesGit/SVN commitsRelated reports
 [2021-07-27 15:48 UTC] cmb@php.net
When implicitly flushing on close, the return value is not
checked[1]; that *might* be deliberate, given that almost none of
the implicit flushes checks the return value.

[1] <https://github.com/php/php-src/blob/php-7.4.21/main/streams/streams.c#L450>
 [2021-08-18 11:10 UTC] cmb@php.net
-Status: Open +Status: Duplicate -Assigned To: +Assigned To: cmb
 [2021-08-18 11:10 UTC] cmb@php.net
Actually, this is a special case of bug #60110, so I'm closing
this ticket as duplicate.
 
PHP Copyright © 2001-2024 The PHP Group
All rights reserved.
Last updated: Sat Nov 23 13:01:29 2024 UTC