|
|
php.net | support | documentation | report a bug | advanced search | search howto | statistics | random bug | login |
[2018-09-07 11:17 UTC] wojciech dot mocek at gmail dot com
Description:
------------
Problem:
Possible to create Datetime from wrong month day. Example:
1. new \Datetime('2018-09-31') => gives 2018-10-01
2. new \Datetime('2018-02-31') => gives 2018-03-03
and it applies to all months having less than 31 days.
There is no such date like 31 of September or 31 of February, or 31 of November, and so on, while PHP library parses such invalid date string and creates Datetime object.
Test script:
---------------
$ php <<< "<?php var_dump(new \Datetime('2018-09-31'), new \Datetime('2018-02-31'));"
-:1:
class DateTime#1 (3) {
public $date => string(26) "2018-10-01 00:00:00.000000"
public $timezone_type => int(3)
public $timezone => string(13) "Europe/Berlin"
}
-:1:
class DateTime#2 (3) {
public $date => string(26) "2018-03-03 00:00:00.000000"
public $timezone_type => int(3)
public $timezone => string(13) "Europe/Berlin"
}
Expected result:
----------------
Expected behaviour:
It should not be possible to create \Datetime object using invalid day of month.
$ php <<< "<?php var_dump(new \Datetime('2018-09-31'));"
PHP Fatal error: Uncaught Exception: DateTime::__construct(): Failed to parse time string (2018-09-31) at position 9 (2): Unexpected character in -:1
Stack trace:
#0 -(1): DateTime->__construct('2018-09-31')
#1 {main}
thrown in - on line 1
Actual result:
--------------
$ php <<< "<?php var_dump(new \Datetime('2018-09-31'), new \Datetime('2018-02-31'));"
-:1:
class DateTime#1 (3) {
public $date => string(26) "2018-10-01 00:00:00.000000"
public $timezone_type => int(3)
public $timezone => string(13) "Europe/Berlin"
}
-:1:
class DateTime#2 (3) {
public $date => string(26) "2018-03-03 00:00:00.000000"
public $timezone_type => int(3)
public $timezone => string(13) "Europe/Berlin"
}
PatchesPull RequestsHistoryAllCommentsChangesGit/SVN commits
|
|||||||||||||||||||||||||||||||||||||
Copyright © 2001-2024 The PHP GroupAll rights reserved. |
Last updated: Sat Dec 21 15:01:29 2024 UTC |
You wrote: 1. "That's right, it does not validate the date." Well, hmm, I just run script: $ php <<< "<?php var_dump(new \Datetime('2018-09-32'), new \Datetime('2018-02-32'));" PHP Fatal error: Uncaught Exception: DateTime::__construct(): Failed to parse time string (2018-09-32) at position 9 (2): Unexpected character in Standard input code:1 Stack trace: #0 Standard input code(1): DateTime->__construct('2018-09-32') #1 {main} thrown in Standard input code on line 1 So it looks that is validates given input somehow. 2. "It tries its best to come up with the most reasonable interpretation of the string passed to it. Just like how strtotime does.". Come on, please ask people around to do something on "2018-02-31", I think noone will think to do it on "2018-03-03" My question #2 is: do you say that if tell me "Send this mail on 2018-02-31" it is MOST REASONABLE to interpret this as "send it on 2018-03-03" ?! 3. "It tries its best to come up with the most reasonable interpretation of the string passed to it. Just like how strtotime does." . You mentioned about strtotime: $ php <<< "<?php var_dump(strtotime('2018-02-31'));" int(1520035200) $ php <<< "<?php var_dump(strtotime('2018-02-32'));" bool(false) $ php <<< "<?php var_dump(new \Datetime('2018-02-32'));" PHP Fatal error: Uncaught Exception: DateTime::__construct(): Failed to parse time string (2018-02-32) at position 9 (2): Unexpected character in Standard input code:1 Stack trace: #0 Standard input code(1): DateTime->__construct('2018-02-32') #1 {main} thrown in Standard input code on line 1 - 31 of February - there is no such date ever in calendar, but PHP creates time. - 32 of February - also there is no such date ever in calendar, PHP forbids to create time "It tries its best to come up with the most reasonable interpretation of the string passed to it" - if it is possible to create time from "never existing 31 of February", so why it is not possible to create time from also "never existing 32 of February" ? 3. In normal life we cannot do anything on 31 of February, nor 31 of September. If you write business application for invoicing, banks, anything, you must validate the date. And if someone writes 31 of February to for example pay tax or send cash, it is mistake and NOT REASONABLE to process. So "day of month" validation should be implemented. Otherwise all business applications will have to use some custom PHP date library, only because native PHP allows to create such nonsense like date from '2018-02-31'.And how should the following be handled? new DateTime('2018-01-31 +1 month')Obviously, new DateTime('2018-01-31 +1 month') and new DateTime('2018-02-31') should both evaluate to the same value, shouldn't they?You asked "should both evaluate to the same value, shouldn't they?". So the answer is: no, they should not. This is how it was solved in other object language: $ docker container run --rm -it openjdk jshell Oct 25, 2019 11:21:53 PM java.util.prefs.FileSystemPreferences$1 run INFO: Created user preferences directory. | Welcome to JShell -- Version 13.0.1 | For an introduction type: /help intro jshell> var dateA = java.time.LocalDate.parse("2018-01-31"); jshell> dateA.plusMonths(1) $2 ==> 2018-02-28 jshell> var dateB = java.time.LocalDate.parse("2018-02-31"); | Exception java.time.format.DateTimeParseException: Text '2018-02-31' could not be parsed: Invalid date 'FEBRUARY 31' (...) Do you agree that PHP DateTime class is class for handling date and time? If yes, then do you agree that it should behave according to real date&time? If yes, then do we have in our calendar date '2018-02-31'?I encountered this issue on PHP 7.4.1 NTS x64. I tested a few more edge cases where an exception was expected but instead a DateTime object was created: # The zeroeth day of the month should not be accepted. var_dump(new DateTime('2020-01-00')); // "2019-12-31 00:00:00.000000" # The zeroeth month of the year should not be accepted. var_dump(new DateTime('2020-00-00')); // "2019-11-30 00:00:00.000000" # I'm not sure whether year 10000 should be accepted. var_dump(new DateTime('10000-01-01')); // "2000-01-01 10:00:00.000000" Like wojciech said, this is not representative of real life scenarios. The end result is that we have to write extra boilerplate validation to handle such edge cases.