Description:
------------
The sockets module from php 7.2.0RC3 (and earlier RCs and betas) fails to build on Mac OS X 10.5 and earlier:


ext/sockets/sockets.c: In function ‘zm_startup_sockets’:
ext/sockets/sockets.c:805: error: ‘AI_NUMERICSERV’ undeclared (first use in this function)


Here's a full build log:

https://build.macports.org/builders/ports-10.5_ppc_legacy-builder/builds/41128/steps/install-port/logs/stdio


The php 7.1.x and earlier versions of the sockets module build fine on the same system.


AI_NUMERICSERV was introduced in Mac OS X 10.6. If you want to use it but remain compatible with older systems, you can apparently define it to 0 if it's not defined:

https://www.mail-archive.com/nbd-general@lists.sourceforge.net/msg01052.html


Note that sapi/phpdbg/phpdbg_io.h already contains these lines:

/* Older versions of glibc <= 2.3.0 and <= OS X 10.5 do not have this constant defined */
#ifndef AI_NUMERICSERV
#define AI_NUMERICSERV 0
#endif

The same lines could be added somewhere for the sockets module.