Neither should be valid; way too easy to write messed up code like this...declaring classes within functions, seriously? WTF

There's no reason for that Sorter class to be declared within the function, can be declared outside of it like a normal class.

> There's no reason for that Sorter class to 
> be declared within the function, can be declared outside of it like 
> a normal class.

1) My code example is stupid, but there are PLENTY of reasons why you may want to declare it inside a function. Of course you can declare it outside, but IT'S NOT THE SAME THING: if it is declared inside the function, the class only exists  if and after the function is executed.

2) That possibility has existed since PHP 5.0

3) If you can do it in a "global" function, there's no reason you shouldn't be able to do it in a class method. 

3) Note that in hhvm, rather than removing the ability to do it in a function, they have added the ability to do it in a method. That is, they have fixed the bug already. I don't see a reason why the fix shouldn't be backported to non-dead PHP versions.

For this kind of change, an RFC is required.

Please see: https://wiki.php.net/rfc/howto

> For this kind of change, an RFC is required.

You may have missed this:

> Note: this does work in hhvm. The fix should be backported to all supported versions.

> You may have missed this:
HHVM is not PHP. They are separate entities.

Oh, I see.

Anyway, if you need an RFC, this issue should stay open until somebody writes one. Writing an RFC is part of fixing the issue (or the feature request if you prefer to call it that way).

This is well defined, expected behaviour; There is no issue, or bug.

What you are requesting is a change to the language, and as mentioned, these kinds of changes must go through the RFC process.

Please see: https://github.com/php/php-src/blob/master/CONTRIBUTING.md#feature-requests